Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to customise Label font size and offset #285

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Add ability to customise Label font size and offset #285

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee86da6
add cluster label font size to theme
SerhiiTsybulskyi Oct 16, 2024
87e59f1
add ability to theming label
SerhiiTsybulskyi Oct 16, 2024
e7ef9b4
update doc
SerhiiTsybulskyi Oct 16, 2024
e785008
code review changes
SerhiiTsybulskyi Oct 16, 2024
8c51309
update doc
SerhiiTsybulskyi Oct 16, 2024
5192c01
use js docs
SerhiiTsybulskyi Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/Theme.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ export interface Theme {
label?: {
stroke?: ColorRepresentation;
color: ColorRepresentation;
fontSize?: number;
yOffset?: number;
SerhiiTsybulskyi marked this conversation as resolved.
Show resolved Hide resolved
};
};
}
Expand Down
6 changes: 3 additions & 3 deletions src/symbols/Cluster.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,10 @@ export const Cluster: FC<ClusterProps> = ({
from: {
circlePosition: [center.x, center.y, -1],
circleOpacity: 0,
labelPosition: [0, -offset, 2]
labelPosition: [0, -offset - (theme.cluster?.label?.yOffset ?? 0), 2]
},
to: {
labelPosition: [0, -offset, 2],
labelPosition: [0, -offset - (theme.cluster?.label?.yOffset ?? 0), 2],
circlePosition: position ? [position.x, position.y, -1] : [0, 0, -1],
circleOpacity: opacity
},
Expand Down Expand Up @@ -200,7 +200,7 @@ export const Cluster: FC<ClusterProps> = ({
stroke={theme.cluster.label.stroke}
active={false}
color={theme.cluster?.label.color}
fontSize={12}
fontSize={theme.cluster?.label.fontSize ?? 12}
/>
</a.group>
)}
Expand Down
2 changes: 2 additions & 0 deletions src/themes/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ export interface Theme {
label?: {
stroke?: ColorRepresentation;
color: ColorRepresentation;
fontSize?: number;
yOffset?: number;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add docs to the props

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amcdnl What do you mean? Comment with description above or something else?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

};
};
}
Loading