From 5c6616c325415b61ef17315cd32842395a4c661d Mon Sep 17 00:00:00 2001 From: Julian Miller Date: Tue, 21 May 2024 12:43:36 +0200 Subject: [PATCH] Revert "Fix Coverity dereference before null check issue (#13456)" (#13818) This reverts commit c02f915d42ac9bd1a3c4f2215d703b49b3a2173d since this Coverity issue is a false positive. `EventImpl` is always set when we pass it in the runtime, but the previous change suggests it might be null. The Coverity hit should be ignored instead. --- sycl/source/detail/graph_impl.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sycl/source/detail/graph_impl.hpp b/sycl/source/detail/graph_impl.hpp index bca7d4d529d07..9291f5101f93a 100644 --- a/sycl/source/detail/graph_impl.hpp +++ b/sycl/source/detail/graph_impl.hpp @@ -940,7 +940,7 @@ class graph_impl { void addEventForNode(std::shared_ptr GraphImpl, std::shared_ptr EventImpl, std::shared_ptr NodeImpl) { - if (EventImpl && !(EventImpl->getCommandGraph())) + if (!(EventImpl->getCommandGraph())) EventImpl->setCommandGraph(GraphImpl); MEventsMap[EventImpl] = NodeImpl; }