From 83f877975c97acdb38d84f94dc146571cd522e0e Mon Sep 17 00:00:00 2001 From: Steffen Larsen Date: Mon, 19 Jun 2023 13:28:33 +0100 Subject: [PATCH] [SYCL] Revert recent copy requirements temporarily (#9970) This commit reverts the recently introduced requirements on `is_device_copyable` in copy commands. This is a temporary revert until `sycl::vec` is made trivially copyable, to appropriately satisfy `is_device_copyable` implicitly. --------- Signed-off-by: Larsen, Steffen --- sycl/include/sycl/handler.hpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sycl/include/sycl/handler.hpp b/sycl/include/sycl/handler.hpp index 1463babc8db64..91f3a9aa336fd 100644 --- a/sycl/include/sycl/handler.hpp +++ b/sycl/include/sycl/handler.hpp @@ -2289,8 +2289,8 @@ class __SYCL_EXPORT handler { "Invalid accessor target for the copy method."); static_assert(isValidModeForDestinationAccessor(AccessMode), "Invalid accessor mode for the copy method."); - static_assert(is_device_copyable::value, - "Pattern must be device copyable"); + // TODO: Add static_assert with is_device_copyable when vec is + // device-copyable. // Make sure data shared_ptr points to is not released until we finish // work with it. CGData.MSharedPtrStorage.push_back(Src); @@ -2360,8 +2360,8 @@ class __SYCL_EXPORT handler { "Invalid accessor target for the copy method."); static_assert(isValidModeForDestinationAccessor(AccessMode), "Invalid accessor mode for the copy method."); - static_assert(is_device_copyable::value, - "Pattern must be device copyable"); + // TODO: Add static_assert with is_device_copyable when vec is + // device-copyable. #ifndef __SYCL_DEVICE_ONLY__ if (MIsHost) { // TODO: Temporary implementation for host. Should be handled by memory