Skip to content

Commit

Permalink
[SYCL][Graph] Fix E2E disabled RUN lines
Browse files Browse the repository at this point in the history
We were using the `x` prefix to the `RUN` lit command to comment out a `RUN`
check. However, LIT still detects this as a `RUN` command, which illustrated
in a CI fail of this test recently https://github.com/intel/llvm/actions/runs/10198164930/job/28215254220

Fixed by changing `xRUN` to `RUNx` which I've verified locally is not detected as a
`RUN` command by LIT, and can be used to comment the `RUN` command out.

Relates to intel#14473
  • Loading branch information
EwanC committed Aug 2, 2024
1 parent 06a3902 commit c55a917
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion sycl/test-e2e/Graph/Explicit/host_task_last.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

// Disabled due to https://github.com/intel/llvm/issues/14473
// Extra run to check for immediate-command-list in Level Zero
// xRUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
// RUNx: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}

// REQUIRES: aspect-usm_shared_allocations

Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/Graph/RecordReplay/host_task_last.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

// Disabled due to https://github.com/intel/llvm/issues/14473
// Extra run to check for immediate-command-list in Level Zero
// xRUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
// RUNx: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}

// REQUIRES: aspect-usm_shared_allocations

Expand Down

0 comments on commit c55a917

Please sign in to comment.