Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mixed host/buffer memcpy #196

Closed
Bensuo opened this issue May 29, 2023 · 0 comments
Closed

Support mixed host/buffer memcpy #196

Bensuo opened this issue May 29, 2023 · 0 comments
Labels
Graph Implementation Related to DPC++ implementation and testing

Comments

@Bensuo
Copy link
Collaborator

Bensuo commented May 29, 2023

#192 implements buffer based memory copies but mixed host and buffer copies require some extra implementation work as it requires some special handling for each case. These are considered a lower priority so can be done separately.

New E2E tests should also be added for this usage.

@Bensuo Bensuo added the Graph Implementation Related to DPC++ implementation and testing label May 29, 2023
mfrancepillois added a commit that referenced this issue Jun 27, 2023
…uffers

Adds support required to handle:
    - host to buffer memcpy for 1d and 2d buffers
    - buffer to host memcpy for 1d and 2d buffers
This commit also fixes a bug in buffer to buffer memcpy enabling to copy
from/to buffers accessed with user-defined offsets.

Adds basic tests to check all use-cases of mixed host/buffer memcpy, and
buffer to buffer memcpy with user-defined offsets.

Addresses Issue: #196
mfrancepillois added a commit that referenced this issue Jun 27, 2023
…uffers (#238)

Adds support required to handle:
    - host to buffer memcpy for 1d and 2d buffers
    - buffer to host memcpy for 1d and 2d buffers
This commit also fixes a bug in buffer to buffer memcpy enabling to copy
from/to buffers accessed with user-defined offsets.

Adds basic tests to check all use-cases of mixed host/buffer memcpy, and
buffer to buffer memcpy with user-defined offsets.

Addresses Issue: #196
EwanC pushed a commit that referenced this issue Jun 29, 2023
…uffers (#238)

Adds support required to handle:
    - host to buffer memcpy for 1d and 2d buffers
    - buffer to host memcpy for 1d and 2d buffers
This commit also fixes a bug in buffer to buffer memcpy enabling to copy
from/to buffers accessed with user-defined offsets.

Adds basic tests to check all use-cases of mixed host/buffer memcpy, and
buffer to buffer memcpy with user-defined offsets.

Addresses Issue: #196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graph Implementation Related to DPC++ implementation and testing
Projects
None yet
Development

No branches or pull requests

2 participants