Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with HowTo.md doc #4

Open
esaminu opened this issue Jan 19, 2022 · 1 comment
Open

Issues with HowTo.md doc #4

esaminu opened this issue Jan 19, 2022 · 1 comment

Comments

@esaminu
Copy link

esaminu commented Jan 19, 2022

Hello all, I found a couple of issues with the HowTo.md doc on this repo:

  1. The nearkey install command appears to be broken. The url needs to be github.com/aurora-is-near/near-api-go/cmd/nearkey in my testing. The command should be
go install github.com/aurora-is-near/near-api-go/cmd/nearkey@latest
  1. The create_staking_pool function call in step 7 of the Deploy Stake&Farm section appears to be missing the owner_id property in the arguments like in the source code of the contract.
  2. There's an extra single quote in step 9 of the Deploy Stake&Farm section. The command should be:
near view ${WHITELIST} is_whitelisted '{"staking_pool_account_id":"'${STAKINGCONTRACT}'"}'
  1. The claim function call in the Cashing out farmed tokens section appears to mismatch the arguments in the source code of the function.
@JonathanLogan
Copy link
Contributor

Good finds. Please create a pull request and contribute :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants