Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reflex upgrade should add new configuration variables for rules when they get added #289

Open
mcbanderson opened this issue Dec 21, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@mcbanderson
Copy link
Contributor

Currently, running reflex upgrade will only bump rule versions in reflex.yaml, but if new configuration variables were added to the rule these are not added to reflex.yaml. This doesn't break anything for minor version increases in rules (which would occur if the new variable has a default value provided), but could break rules if there was a major version bump that required new configuration variables.

To fix this we should have reflex upgrade include any new configuration options when bumping the rule version, or provide a flag for triggering this functionality.

To test this we can use the change from s3-bucket-not-encrypted going from v2.1.9 -> v2.2.0, which added the encryption_key configuration variable.

@mcbanderson mcbanderson added the enhancement New feature or request label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant