Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal execution button not rendering correctly #137

Open
ryanchristo opened this issue Aug 9, 2023 · 1 comment
Open

Proposal execution button not rendering correctly #137

ryanchristo opened this issue Aug 9, 2023 · 1 comment
Labels
dev Engineering task good first issue Good for newcomers

Comments

@ryanchristo
Copy link
Member

While working on #133, an issue with the FormFooter component came up where the button is not rendering the correct text. It looks like the following code in combination with the page updating is causing the issue:

// wipe state if footer removed from DOM
useEffect(() => {
return () => setFooterActions({})
}, [setFooterActions])

Currently the button says "Submit" rather than "Execute" on initial load but everything else is working as expected.

@ryanchristo
Copy link
Member Author

This does not appear to be an issue in production, will need to investigate further but maybe not an immediate concern:

Screenshot from 2023-08-10 13-23-30

@ryanchristo ryanchristo added dev Engineering task good first issue Good for newcomers labels Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Engineering task good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant