-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users can view empty credit batches they previously held. #1949
Comments
This issue comes from the ledger originally which doesn't prune credit batches with empty balance: regen-network/regen-ledger#1889 but such credit batches should be hidden already on the front-end, this was done as part of #1853 |
They should be hidden indeed, it might be a regression or another case that is not handled. |
Is this the same as what was resolved in #1979? Can we close this issue or is this something different? |
same as what was resolved in #1979 |
Describe the bug
In my user profile I can view credit batches I previously held, but no longer hold.
To Reproduce
Expected behavior
Once I sell, or transfer a credit batch and no longer hold credits of that batch, they should disappear from the user profile.
Screenshots
![image](https://private-user-images.githubusercontent.com/67330492/249900714-8c71d27f-41bd-4e80-b87a-28c7e2329dc4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5NDI2NjksIm5iZiI6MTcyNTk0MjM2OSwicGF0aCI6Ii82NzMzMDQ5Mi8yNDk5MDA3MTQtOGM3MWQyN2YtNDFiZC00ZTgwLWI4N2EtMjhjN2UyMzI5ZGM0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDA0MjYwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVmOWNkMzdjNjM2MzhhNTczZTk0M2NmOTQ2Nzk0MTgyMzc1ZjkyNjVkZGQxNDc1ZmMxYzA5NTY1YzIzY2FhNDYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.G3EvZWstqk72BWX8wP1Op-r7A_M3IJj8cI0kN5Aep4E)
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
For Admin Use
The text was updated successfully, but these errors were encountered: