Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors in computing events for very small polygons #5

Open
michalstaron opened this issue Mar 12, 2020 · 1 comment
Open

Errors in computing events for very small polygons #5

michalstaron opened this issue Mar 12, 2020 · 1 comment

Comments

@michalstaron
Copy link

Line:

csharp-libs/straight_skeleton/StraightSkeletonNet/SkeletonBuilder.cs

Line 899 in c5cd4ce

if (Math.Abs(distance1 - SplitEpsilon) < distance2)

should be:
Math.Abs(Math.Max(0, distance1 - SplitEpsilon))
Line:

csharp-libs/straight_skeleton/StraightSkeletonNet/SkeletonBuilder.cs

Line 901 in c5cd4ce

if (Math.Abs(distance2 - SplitEpsilon) < distance1)

should be:
Math.Abs(Math.Max(0, distance2 - SplitEpsilon))
@reinterpretcat
Copy link
Owner

Hi! Thanks for reporting it, can you make a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reinterpretcat @michalstaron