-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rsapi Unit tests are not properly using VerifyAll #142
Labels
Comments
#143 was not a fix; it was just a related dead-code removal. |
@aarongilbert123 Assigning it to you was a suggestion; if you don't want it, unassign yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our provider tests are supposed to call
mockProvider.VerifyAll
after every test. But the code to do so is decorated with aSetUp
attribute instead of aTearDown
attribute, which never fires. Here is an example:Gravity/Gravity/Gravity.Test.Unit/RsapiDaoInsertTests.cs
Lines 41 to 46 in a4874bc
Flipping this value shows that 10 tests are not written to meet the verification criterion:
In the process of fixing this, we should create a base unit test class to handle the
mockProvider
setup and verification.The text was updated successfully, but these errors were encountered: