You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tests should ensure history.push and history.replace work with to: Partial<Path>.
Actual behavior
All test sequences only test with to: string.
Details
This seems to be an oversight with the tests. Both history.push and history.replace have a first argument of type To. The type definition for To allows two options: Partial<Path> and string.
However, it seems that all test sequences call push and replace with strings, never with objects that contain keys of Path. I've created a PR that solves this issue.
The text was updated successfully, but these errors were encountered:
Expected behavior
Tests should ensure
history.push
andhistory.replace
work withto: Partial<Path>
.Actual behavior
All test sequences only test with
to: string
.Details
This seems to be an oversight with the tests. Both
history.push
andhistory.replace
have a first argument of typeTo
. The type definition forTo
allows two options:Partial<Path>
andstring
.However, it seems that all test sequences call
push
andreplace
with strings, never with objects that contain keys ofPath
. I've created a PR that solves this issue.The text was updated successfully, but these errors were encountered: