Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test improvement: push and replace of Partial<Path> #920

Open
thejohnhoffer opened this issue Dec 21, 2021 · 0 comments
Open

Test improvement: push and replace of Partial<Path> #920

thejohnhoffer opened this issue Dec 21, 2021 · 0 comments

Comments

@thejohnhoffer
Copy link

Expected behavior

Tests should ensure history.push and history.replace work with to: Partial<Path>.

Actual behavior

All test sequences only test with to: string.

Details

This seems to be an oversight with the tests. Both history.push and history.replace have a first argument of type To. The type definition for To allows two options: Partial<Path> and string.

However, it seems that all test sequences call push and replace with strings, never with objects that contain keys of Path. I've created a PR that solves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant