Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory structure rationalization #43

Open
septract opened this issue Jul 15, 2024 · 7 comments
Open

Directory structure rationalization #43

septract opened this issue Jul 15, 2024 · 7 comments

Comments

@septract
Copy link
Collaborator

We should reorganize the directory structure to be more reasonable. Currently it looks like this:

cn-tutorial/
├─ check.sh
├─ Makefile
├─ src/
│  ├─ tutorial.adoc
│  ├─ examples/
│  │  ├─ 3.c
│  │  ├─ ...
│  ├─ example-archive/
│  │  ├─ check-all.sh
│  │  ├─ check.sh
│  │  ├─ simple-examples/
│  │  │  ├─ working/
│  │  │  ├─ broken/
│  │  ├─ .../

Some anomalies:

  • The example-archive folder is buried, and we might want to lift it to the top level
  • Examples are categorized by name in src/examples but by folder in src/example-archive/

@bcpierce00

@thatplguy
Copy link
Collaborator

Perhaps we can move example-archive into the CN repo, once it's split from the Cerberus repo? As remarked in the past, the example archive is less about teaching CN to new users and more for characterizing CN capabilities for us (tool developers) and for regression testing.

I hear from @dc-mak that the CN/Cerberus repo split is underway and will hopefully be complete in the not too distant future.

@bcpierce00
Copy link
Collaborator

bcpierce00 commented Jul 15, 2024 via email

@thatplguy
Copy link
Collaborator

I think some duplication is OK? I don't think it's a problem if the tutorial examples change independently of the example archive (e.g. improving readability, adding comments, etc.), and any structural changes we need to make, like syntax changes, will be more painful due to the number of examples in the archive rather than the relatively small bit of duplication.

@bcpierce00
Copy link
Collaborator

bcpierce00 commented Jul 15, 2024 via email

@septract
Copy link
Collaborator Author

Agree. We should probably colocate example-archive with the CN test-cases that are already in the cerberus repo here.

@bcpierce00
Copy link
Collaborator

bcpierce00 commented Jul 15, 2024 via email

@cp526
Copy link
Collaborator

cp526 commented Jul 16, 2024

That's what I was thinking too: having everything, including the tutorial, in one place will make the CI setup smoother.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants