packageRules cannot combine both matchUpdateTypes and versioning

[cclaes-dsi]

What would you like help with?

I think I found a bug

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

No response

Please tell us more about your question or problem

I am currently trying to configure Renovate to update our RedHat container image in a Dockerfile. I can't use versioning and matchUpdateTypes in packageRules, but this isn't mentioned in the docs anywhere.

I was under the impression the following config should work:

"packageRules": [
    {
      "automerge": true,
      "automergeType": "branch",
      "groupName": "Container minors and patches",
      "groupSlug": "container-minor-patch",
      "matchManagers": [
        "dockerfile"
      ],
      "matchDatasources": [
        "docker"
      ],
      "matchPackageNames": [
        "registry.access.redhat.com/rhel",
        "registry.access.redhat.com/rhel-atomic",
        "registry.access.redhat.com/rhel-init",
        "registry.access.redhat.com/rhel-minimal",
        "registry.access.redhat.com/rhceph/**",
        "registry.access.redhat.com/rhgs3/**",
        "registry.access.redhat.com/rhel7**",
        "registry.access.redhat.com/rhel8/**",
        "registry.access.redhat.com/rhel9/**",
        "registry.access.redhat.com/rhscl/**",
        "registry.access.redhat.com/ubi7**",
        "registry.access.redhat.com/ubi8**",
        "registry.access.redhat.com/ubi9**",
        "registry.access.redhat.com/ubi9/**",
        "redhat/**"
      ],
      "matchUpdateTypes": [
        "minor",
        "patch"
      ],
      "versioning": "redhat"
    },
    {
      "matchManagers": [
        "dockerfile"
      ],
      "matchDatasources": [
        "docker"
      ],
      "matchPackageNames": [
        "registry.access.redhat.com/rhel",
        "registry.access.redhat.com/rhel-atomic",
        "registry.access.redhat.com/rhel-init",
        "registry.access.redhat.com/rhel-minimal",
        "registry.access.redhat.com/rhceph/**",
        "registry.access.redhat.com/rhgs3/**",
        "registry.access.redhat.com/rhel7**",
        "registry.access.redhat.com/rhel8/**",
        "registry.access.redhat.com/rhel9/**",
        "registry.access.redhat.com/rhscl/**",
        "registry.access.redhat.com/ubi7**",
        "registry.access.redhat.com/ubi8**",
        "registry.access.redhat.com/ubi9**",
        "registry.access.redhat.com/ubi9/**",
        "redhat/**"
      ],
      "matchUpdateTypes": [
        "major"
      ],
      "versioning": "redhat"
    }
  ]

This way we can separate the major updates from the others and avoid auto merging. This isn't possible though and I don't understand why, since the debug logs clearly display the update type when I remove the matchUpdateTypes.

"updates": [
              {
                "bucket": "non-major",
                "newVersion": "9.4-1227",
                "newValue": "9.4-1227",
                "newMajor": 9,
                "newMinor": 4,
                "newPatch": 0,
                "updateType": "minor",
                "branchName": "feature/container-minor-patch"
              }
            ],

If this is intended behavior, how can I work around this and achieve the above solution?

Thanks in advance!

Logs (if relevant)

Logs

INFO: Repository has invalid config
{
  "error": {
    "validationSource": ".github/renovate.json",
    "validationError": "The renovate configuration file contains some invalid settings",
    "validationMessage": "packageRules[0]: packageRules cannot combine both matchUpdateTypes and versioning. Rule: {\"automerge\":true,\"automergeType\":\"branch\",\"groupName\":\"Container minors and patches\",\"groupSlug\":\"container-minor-patch\",\"matchManagers\":[\"dockerfile\"],\"matchDatasources\":[\"docker\"],\"matchPackageNames\":[\"registry.access.redhat.com/rhel\",\"registry.access.redhat.com/rhel-atomic\",\"registry.access.redhat.com/rhel-init\",\"registry.access.redhat.com/rhel-minimal\",\"registry.access.redhat.com/rhceph/**\",\"registry.access.redhat.com/rhgs3/**\",\"registry.access.redhat.com/rhel7**\",\"registry.access.redhat.com/rhel8/**\",\"registry.access.redhat.com/rhel9/**\",\"registry.access.redhat.com/rhscl/**\",\"registry.access.redhat.com/ubi7**\",\"registry.access.redhat.com/ubi8**\",\"registry.access.redhat.com/ubi9**\",\"registry.access.redhat.com/ubi9/**\",\"redhat/**\"],\"matchUpdateTypes\":[\"minor\",\"patch\"],\"versioning\":\"redhat\"}, packageRules[1]: packageRules cannot combine both matchUpdateTypes and versioning. Rule: {\"matchManagers\":[\"dockerfile\"],\"matchDatasources\":[\"docker\"],\"matchPackageNames\":[\"registry.access.redhat.com/rhel\",\"registry.access.redhat.com/rhel-atomic\",\"registry.access.redhat.com/rhel-init\",\"registry.access.redhat.com/rhel-minimal\",\"registry.access.redhat.com/rhceph/**\",\"registry.access.redhat.com/rhgs3/**\",\"registry.access.redhat.com/rhel7**\",\"registry.access.redhat.com/rhel8/**\",\"registry.access.redhat.com/rhel9/**\",\"registry.access.redhat.com/rhscl/**\",\"registry.access.redhat.com/ubi7**\",\"registry.access.redhat.com/ubi8**\",\"registry.access.redhat.com/ubi9**\",\"registry.access.redhat.com/ubi9/**\",\"redhat/**\"],\"matchUpdateTypes\":[\"major\"],\"versioning\":\"redhat\"}",
    "message": "config-validation",
    "stack": "Error: config-validation\n    at mergeRenovateConfig (/usr/local/renovate/lib/workers/repository/init/merge.ts:198:19)\n    at processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at getRepoConfig (/usr/local/renovate/lib/workers/repository/init/config.ts:14:12)\n    at initRepo (/usr/local/renovate/lib/workers/repository/init/index.ts:56:12)\n    at Object.renovateRepository (/usr/local/renovate/lib/workers/repository/index.ts:64:14)\n    at attributes.repository (/usr/local/renovate/lib/workers/global/index.ts:202:11)\n    at start (/usr/local/renovate/lib/workers/global/index.ts:187:7)\n    at /usr/local/renovate/lib/renovate.ts:18:22"
  }
}

[github-actions[bot]]

Hi there,

A maintainer decided this is not a bug, and behaving as designed. The maintainer will explain why this behavior is correct. To avoid confusing future readers, we will close this Discussion.

We want Bug-type Discussions to be about things that we rate as bugs. For more details, please read our development docs about bug handling.

If this bug report makes you think of an idea for a new feature, or how to improve a current feature, feel free to create a new Suggest an Idea Discussion.

Thanks, the Renovate team

[rarkins]

It's logically impossible to combine these two. Renovate needs versioning before updates can be calculated.

[frjonsen]

Could you explain how this should be done? We have the same issue, where we first want to "explain" how to parse the versions, and after that, match on update type so that minor and patch versions can be automerged. If versioning and matchUpdateType cannot be combined, how should we configure it?

For some additiona details, we use datetime based versions for internal libs, such as 2024.11.20.1230. We also build artifacts on branches, versioned as 2024.11.20.1230-my-feature-branch.100 (the latter part being build number). If we don't set versioning, then renovate identifies the latter as a patch update, and wants to automerge it, if we enabled automerge for minor and patch versions.

This is how we tried to configure it, and also got errors on invalid config:

{
  "matchDatasources": ["maven"],
  "versioning": "regex:^(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<patch>\\d+)\\.(?<build>\\d+)(?<prerelease>-.*)?$",
  "matchUpdateTypes": ["minor", "patch", "build"]
}

[rarkins]

You need to use separate packageRules. For any further information, please create a new discussion and include a reproduction repo