renovate-config-validator issue with group presets in packageRules

[cchristous]

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

github.com, renovatebot 38.26.1, ghcr.io/mend/renovate-ce:8.1.1

Please tell us more about your question or problem

Hi,

I am running the renovate-config-validator against my global config, and it is failing (see the details in the log below) for a new change that I made. My change was to add preset groups into a package rule. It seems that this is not allowed, and the discussion in #26728 backs this up. I am wondering if there is a different way to achieve the grouping behavior that I desire.

My intended grouping behavior is (highest precedence at the top):

1. Security fixes must always be each in isolated PRs. 1 PR per 1 package
2. Minor and patch changes must always be in a single PR. 1 PR for all packages
3. Major changes that are part of a monorepo should be grouped together. 1 PR for each monorepo group
4. Major changes that are not part of a monorepo should be in isolated PRs. 1 PR per 1 package

I'd also like to add that renovatebot behaves as desired (AFAIK) with my configuration. It is just the validator that doesn't like the configuration.

The relevant part of the config is:

  packageRules: [
...
    {
      "matchUpdateTypes": ["major"],
      "extends": [
        "group:monorepos",
        "group:recommended",
      ],
    },
...
    {
      "matchDatasources": ["maven"],
      "groupName": "maven dependencies",
      "matchUpdateTypes": ["minor", "patch"],
    },
...

Full config

module.exports = {
  "extends": [
    ":semanticPrefixFixDepsChoreOthers",
    ":ignoreModulesAndTests",
    "replacements:all",
    "workarounds:all",
    ":pinDevDependencies",
    "mergeConfidence:all-badges",
  ],
  cachePrivatePackages: true,
  fetchChangeLogs: "off",
  baseBranches: ["main", "master", "/^[7-9]\\.\\d+\\.x$/"],
  requireConfig: "optional",
  enabledManagers: ["bazel", "custom.regex", "pip_requirements", "pipenv", "gomod", "maven"],
  allowedPostUpgradeCommands: [
    ".*bazel run .*$",
  ],
  secrets: {
    CODEARTIFACT_AUTH_TOKEN: process.env.CODEARTIFACT_AUTH_TOKEN,
    RENOVATEBOT_GITHUB_TOKEN: process.env.RENOVATEBOT_GITHUB_TOKEN,
  },
  customEnvVariables: {
    CODEARTIFACT_AUTH_TOKEN: "{{ secrets.CODEARTIFACT_AUTH_TOKEN }}",
  },
  postUpdateOptions: ["gomodTidy", "gomodUpdateImportPaths"],
  osvVulnerabilityAlerts: true,
  constraints:{
    "pipenv": "2024.0.3",
  },
  packageRules: [
    // common settings
    {
      "enabled": true,
      "matchDatasources": ["go", "maven", "pypi"],
      "matchUpdateTypes": ["major", "minor", "patch"],
    },
    {
      "matchDatasources": ["go", "maven", "pypi"],
      "rangeStrategy": "widen",
    },
    {
      "matchUpdateTypes": ["major"],
      "extends": [
        "group:monorepos",
        "group:recommended",
      ],
    },

    // bazel settings
    {
      "enabled": false,
      "matchDatasources": ["bazel"],
      "matchPackageNames": ["redacted_rules"],
    },
    {
      "matchDatasources": ["bazel"],
      "groupName": "bazel dependencies",
      "matchUpdateTypes": ["minor", "patch"],
    },

    // go settings
    {
      "matchDatasources": ["go"],
      "groupName": "golang dependencies",
      "matchUpdateTypes": ["minor", "patch"],
    },
    {
      "enabled": false,
      "matchDatasources": ["go"],
      "matchDepTypes": ["replace"],
    },
    {
      "enabled": false,
      "matchDatasources": ["golang-version"],
    },

    // maven settings
    {
      "matchDatasources": ["maven"],
      "matchFileNames": [
        "**/*.bazel",
        "**/*.bzl",
      ],
      "postUpgradeTasks": {
        "commands": [
          "REPIN=1 bazel run @maven//:pin"
        ],
        "executionMode": "branch"
      },
    },
    {
      "matchDatasources": ["maven"],
      "matchPackageNames": ["*redacted-package*"],
      "registryUrls": ["https://aws:{{ secrets.CODEARTIFACT_AUTH_TOKEN }}@redacted-registry/maven/maven"],
    },
    {
      "matchDatasources": ["maven"],
      "groupName": "maven dependencies",
      "matchUpdateTypes": ["minor", "patch"],
    },
    {
      "groupName": "org.apache.kafka major dependencies",
      "matchUpdateTypes": ["major"],
      "matchPackageNames": ["org.apache.kafka*"],
    },

    // pypi settings
    {
      "matchFileNames": [
        "**/requirements.in",
        "**/requirements-test.in",
      ],
      "postUpgradeTasks": {
        "commands": [
          "export PIP_CONFIG_FILE=/home/ubuntu/.config/pip/pip.conf && bazel run //:requirements.update"
        ],
        "executionMode": "branch"
      },
    },
    {
      "matchDatasources": ["pypi"],
      "registryUrls": ["https://aws:{{ secrets.CODEARTIFACT_AUTH_TOKEN }}@redacted-registry/pypi/pypi/simple/"],
    },
    {
      "matchDatasources": ["pypi"],
      "groupName": "pypi dependencies",
      "matchUpdateTypes": ["minor", "patch"],
    },
    {
      "matchPackageNames": [
        "redacted-package-2",
        "redacted-package-3",
        "redacted-package-4",
      ],
      "rangeStrategy": "bump",
    },
  ],
  bazel: {
    "fileMatch": [
      "(^|/)WORKSPACE(|\\.bazel|\\.bzlmod)$"
    ]
  },
  pip_requirements: {
    "fileMatch": [
      "^requirements.*\\.in$"
    ]
  },
  hostRules: [
    {
      "matchHost": "redacted-registry",
      "username": "aws",
      "password": "{{ secrets.CODEARTIFACT_AUTH_TOKEN }}",
      "readOnly": true,
    },
    {
      "matchHost": "https://github.com/redacted-org",
      "token": "{{ secrets.RENOVATEBOT_GITHUB_TOKEN }}",
      "hostType": "go",
      "readOnly": true,
    },
    {
      "matchHost": "https://api.github.com/repos/redacted-org",
      "token": "{{ secrets.RENOVATEBOT_GITHUB_TOKEN }}",
      "hostType": "github",
      "readOnly": true,
    }
  ]
}

Logs (if relevant)

Logs

npx --yes --package renovate -- renovate-config-validator docker/global_config.js --strict
npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated rimraf@2.4.5: Rimraf versions prior to v4 are no longer supported
npm warn deprecated glob@6.0.4: Glob versions prior to v9 are no longer supported
 INFO: Validating docker/global_config.js
ERROR: Found errors in configuration
       "file": "docker/global_config.js",
       "errors": [
         {
           "topic": "Configuration Error",
           "message": "packageRules[2]: packageRules cannot combine both matchUpdateTypes and ignoreDeps. Rule: {\"matchUpdateTypes\":[\"major\"],\"extends\":[\"group:monorepos\",\"group:recommended\"]}"
         }
       ]
 WARN: Found errors in configuration
       "file": "docker/global_config.js",
       "warnings": [
         {
           "topic": "Configuration Warning",
           "message": "packageRules[2].extends: you should not extend \"group:\" presets"
         },
         {
           "topic": "Configuration Warning",
           "message": "packageRules[2].extends: you should not extend \"group:\" presets"
         }
       ]

[RahulGautamSingh]

Take the monorepos you want to group, and add the code in separate package rules.

Before:

 {
      "matchUpdateTypes": ["major"],
      "extends": [
        "group:monorepos",
        "group:recommended",
      ],
    },

After: (lets say you want the jest monorepo grouped together)

 {
      "matchUpdateTypes": ["major"],
      "groupName": "jest monorepo",
      "matchPackageNames": [
        "@types/jest"
      ]    
  }

Like this you can search the config for the monorepos you want to group and create single package rules for them.

[cchristous]

While that would technically address the problem. It isn't really a good solution. This is in my global configuration used by my self hosted server that is used by all projects that my team maintains. We'd like to rely upon the great work that others have done to curate a thorough set of monorepos. In your suggestion, I'd have to copy paste thousands of lines of configuration, and as new monorepos are discovered, I'd have to add them too. What is great about the current solution is that I get to rely upon that work, and I get new ones for free.

Are there any other options?

[RahulGautamSingh]

It should still work with a warning only, not an error. If there's an error then maybe something else is wrong.

It seems that the matcher you are trying to use matchUpdateTypes is not compatible for use with some of the other config options used by the preset, thus the error.

Update:
The exact cause for the error is a hack introduced to fix some other bug as ignoreDeps is not needed in the preset config.

I will create an issue from it.

[RahulGautamSingh]

#31986