Semantic commit prefix in monorepo is determined by the order of package.json files #31973
Replies: 2 comments 4 replies
-
Current behavior is expected. Renovate is not aware of fix vs chore or how to decide on which to use if a branch is mixed. |
Beta Was this translation helpful? Give feedback.
4 replies
-
Converted to issue: #31979 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
How are you running Renovate?
A Mend.io-hosted app
If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.
No response
Please tell us more about your question or problem
Minimal reproduction: https://github.com/breadadams/renovate-semantic-commit-repro
The semantic/conventional commit prefix differs based on which is the last package.json in the PR. For example, in the repro we have two packages,
pkg-a
andpkg-b
, with the follow structure re. dependencies:Renovate will open two PRs, performing the following updates:
lodash@4.17.20
→lodash@4.17.21
ramda@0.30.0
→ramda@0.30.1
The problem
The PR updating
lodash
gets thechore
prefix becausepkg-b
is the last package.json to be analysed, and it has it listed underdevDependencies
. Whereasramda
gets thefix
prefix because it's listed underdependencies
inpkg-b
.If I remove
lodash
frompkg-b
both PRs get thefix
prefix.Expected behaviour
We expect both PRs to get the
fix
prefix, since bothlodash
andramda
are listed underdependencies
for at least one of the packages affected by the PR.Logs (if relevant)
Logs
Beta Was this translation helpful? Give feedback.
All reactions