Support custom yarn protocols

[goloveychuk]

Tell us more.

As you know yarn supports custom protocols.
Let's say we written version protocol, which only writes package.json: {name: packageName, version} to node_modules.
Purpose is to pin version, but it doesn't really matter.

Issue is that renovate will not update custom protocols, it only supports builtin (file, npm).

renovate/lib/modules/manager/npm/extract/common/dependency.ts

Line 100 in def0299

if (dep.currentValue.startsWith('npm:')) {

Custom protocol will look like this in package.json:
"depName": "version:^1.3.5"
But of course format could be different (look at patch protocol).

Possible solutions:

1. add customProtocols: string[] in npm manager config and support it in npm manager.
2. add more general matchVersion: string[], which in this case will be "^version:(?<currentValue>)". Advantage that it will support different formats.
3. try to match this cases automatically

if (version.includes(':') {
  const [proto, version] = version.split(':')}; 
  if isValid(version)  {
        ...
  }
}

Wdyt?

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

Please follow these steps:

1. Read our guide on creating a minimal reproduction.
2. Go to our minimal reproduction template repository.
3. Select the Use this template button to create a new repository based on the template.
4. Work on the minimal reproduction in your own repository.
5. Fill out the information in your repository's README.md.
6. Add the link to your reproduction to the first post of your Discussion. If you are not the original author, you can post a new comment with the link.

If you need help with running renovate on your minimal reproduction repository, please refer to our Running Renovate guide.
Good luck,

The Renovate team

[rarkins]

Reproduction needed. Also does Yarn document the protocols it supports?

[goloveychuk]

I'm talking about custom protocols. User-written, user installed.
Currently renovate supports all built-in yarn protocols.

[goloveychuk]

From technical perspective, yarn parses protocol by using this fn
https://github.com/goloveychuk/berry/blob/ad03119d78b54208b0748a70e537727ef7fdd7ba/packages/yarnpkg-core/sources/structUtils.ts#L483
but from what I see, range could be any string as soon as resolver and linker matches it.

[rarkins]

This sounds like something best suited to Renovate's custom manager (using regex) and not something to be built into the npm manager

[goloveychuk]

this is my proposal.
If smth like this does not fit into design, I will do this via custom manager.
I can provide PR.
Thanks

[rarkins]

Unless there's common use of this approach by Yarn users, I would prefer not to adopt it into the core code