Error parsing Cargo.toml file due to ZoD schema validation error

[rarkins]

Discussed in #32523

^{Originally posted by rami3l November 14, 2024}

How are you running Renovate?

A Mend.io-hosted app

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

No response

Please tell us more about your question or problem

Coming from Rustup, we are using the following configuration WRT cargo dependencies:

        {
            "matchManagers": [
                "cargo"
            ],
            "matchUpdateTypes": [
                "patch"
            ],
            "enabled": false
        },
        {
            "matchManagers": [
                "cargo"
            ],
            "matchUpdateTypes": [
                "minor"
            ],
            "matchCurrentVersion": "!/^0/",
            "enabled": false
        },

https://github.com/rust-lang/rustup/blob/c8eddcb4c1dc9aea8067fa73179ce1791aa24d1d/.github/renovate.json#L24-L41

... and we set the lock file maintenance to be executed every Monday. It used to be working alright, at least till the point of 2024/10/28 (rust-lang/rustup#4066), but after that I can no longer see cargo on the dependency dashboard (rust-lang/rustup#3142, you can refer to the editing history of that post as well). The logs say the same:

INFO: Dependency extraction complete
{
  "baseBranch": "master"
  "stats": {
    "managers": {
      "dockerfile": {
        "fileCount": 23,
        "depCount": 23
      },
      "github-actions": {
        "fileCount": 10,
        "depCount": 107
      }
    },
    "total": {
      "fileCount": 33,
      "depCount": 130
    }
  }
}

Many thanks in advance!

[rarkins]

I added the rustup toml/lock to fixtures in #32529 so that we have a "failing" case to then fix

[rami3l]

@rarkins Thanks a lot for the quick response!

Looking at:

It seems to be caused by a Zod validation error:

DEBUG: Error parsing Cargo.toml file (repository=rust-lang/rustup, packageFile=Cargo.toml)
...
         "issues": {"package": {"version": "Expected string, received object"}}

#32523 (comment)

The direct cause of this issue on our side seems to be the migration to workspace-wide properties (rust-lang/rustup@72e2e76).

[mkniewallner]

Sorry for that, I've attempted a fix in #32530. This basically comes from:

[package]
version.workspace = true

The schema always expects a string for package.version, did not notice that it could also be an object.

[rami3l]

Sorry for that, I've attempted a fix in #32530. This basically comes from:

[package]
version.workspace = true

The schema always expects a string for package.version, did not notice that it could also be an object.

@mkniewallner I'm not sure about how this project consumes manifest schemata in general, but we do have a schema for Cargo.toml right now, if it helps: https://github.com/rust-lang/cargo/blob/3ad481e749f64e43041d4c7145906b5ef1c16532/crates/cargo-util-schemas/manifest.schema.json

[viceice]

• refactor(manager/cargo): use zod to parse manifest/config #31260
• feat(manager/cargo): support reading package version from workspace (local only) #32533

[viceice]

Sorry for that, I've attempted a fix in #32530. This basically comes from:

[package]
version.workspace = true

The schema always expects a string for package.version, did not notice that it could also be an object.

@mkniewallner I'm not sure about how this project consumes manifest schemata in general, but we do have a schema for Cargo.toml right now, if it helps: https://github.com/rust-lang/cargo/blob/3ad481e749f64e43041d4c7145906b5ef1c16532/crates/cargo-util-schemas/manifest.schema.json

Nice, @zharinov So you know a way to validate a zod schema agains a json schema? that would probably helpful

[rami3l]

@viceice Thanks a lot for the hard work! May I ask when I am expected to get this fix on Mend.io-hosted instances though?