Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] multiInjectedProviderDiscovery option not working after switching from Wallet Connect to Reown #3295

Open
ErwanDecoster opened this issue Nov 21, 2024 · 1 comment
Labels
bug Something isn't working needs review

Comments

@ErwanDecoster
Copy link

Link to minimal reproducible example

https://codesandbox.io/p/github/ErwanDecoster/Reown-multiInjectedProviderDiscovery-not-working-bug-reproduction/main

Summary

Title: multiInjectedProviderDiscovery option not working after switching from Wallet Connect to Reown


Description

After switching from Wallet Connect to Reown, the multiInjectedProviderDiscovery option in the WagmiAdapter is no longer taken into account.

Here’s the updated setup:

import { WagmiAdapter } from '@reown/appkit-adapter-wagmi';
import { createAppKit } from '@reown/appkit/react';

export const projectId = ""

const bellecour = {
  id: 0x86,
  name: 'iExec Sidechain',
  nativeCurrency: {
    decimals: 18,
    name: 'xRLC',
    symbol: 'xRLC',
  },
  rpcUrls: {
    public: { http: ['https://bellecour.iex.ec'] },
    default: { http: ['https://bellecour.iex.ec'] },
  },
  blockExplorers: {
    etherscan: {
      name: 'Blockscout',
      url: 'https://blockscout-bellecour.iex.ec',
    },
    default: { name: 'Blockscout', url: 'https://blockscout-bellecour.iex.ec' },
  },
};

export const wagmiAdapter = new WagmiAdapter({
  networks: [bellecour],
  multiInjectedProviderDiscovery: false,
  projectId,
});

createAppKit({
  adapters: [wagmiAdapter],
  networks: [bellecour],
  projectId,
  defaultNetwork: bellecour,
});

When using Wallet Connect, the multiInjectedProviderDiscovery option worked as expected. However, after transitioning to Reown, it seems to be ignored.


Expected Behavior

  • The multiInjectedProviderDiscovery option should work as it did previously with Wallet Connect.

Actual Behavior

  • The option is no longer taken into account after switching to Reown.

Environment

  • @reown/appkit: 1.5.0
  • @reown/appkit-adapter-wagmi: 1.5.0

Steps to Reproduce

  1. Set up the WagmiAdapter as shown in the code above.
  2. Transition from Wallet Connect to Reown.
  3. Observe that the multiInjectedProviderDiscovery option no longer functions as expected.

Additional Context

  • The issue arose specifically after switching from Wallet Connect to Reown.
  • Downgrading to Wallet Connect resolves the issue.

Suggested Labels

  • Bug
  • Needs Investigation

Thank You

Thank you for your assistance! Please let me know if additional information is needed.

List of related npm package versions

@reown/appkit
@reown/appkit-adapter-wagmi

@ErwanDecoster ErwanDecoster added bug Something isn't working needs review labels Nov 21, 2024
@arein
Copy link
Contributor

arein commented Dec 12, 2024

@ErwanDecoster mind checking if this is still an issue on 1.6.0? also curious why you want to disable multiInjectedProviderDiscovery in the first place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs review
Projects
None yet
Development

No branches or pull requests

2 participants