Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ethers loading hanging state #1702

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Fix ethers loading hanging state #1702

merged 5 commits into from
Jan 4, 2024

Conversation

svenvoskamp
Copy link
Contributor

Changes

  • fix: Fix ethers loading hanging state

@vercel Vercel
Copy link

vercel bot commented Jan 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jan 4, 2024 2:52pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jan 4, 2024 2:52pm
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Jan 4, 2024 2:52pm
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Jan 4, 2024 2:52pm

arein
arein reviewed Jan 4, 2024
View reviewed changes
Copy link
Contributor

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide an explainer of what the bug was? There's no test updates so it's hard to assess what the issue is?

@svenvoskamp
Copy link
Contributor Author

Can you provide an explainer of what the bug was? There's no test updates so it's hard to assess what the issue is?

There was a state when getLoginEmailUsed() returns true, but connection couldn't succeed, because of Magic RPC Error: [-32603] Internal error: User denied account access. which kept button in loading state.

tomiir
tomiir approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@tomiir tomiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@svenvoskamp svenvoskamp merged commit 794224d into V3 Jan 4, 2024
11 of 12 checks passed
@svenvoskamp svenvoskamp deleted the fix/ethers-loading-hanging branch January 4, 2024 15:19
@tomiir tomiir mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arein arein arein left review comments

@tomiir tomiir tomiir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svenvoskamp @arein @tomiir