Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update cacao identity resolution #46

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

Elyniss
Copy link
Contributor

@Elyniss Elyniss commented Sep 7, 2023

Description

Required by WalletConnect/walletconnect-specs#139
The identity key will no longer be in Cacao resources but in the audience. In order to avoid breaking changes we accept both versions. If Identity Key is present in both resources and audience the latter is taken.

Resolves #45

How Has This Been Tested?

Unit tests supported by data generated by Kotlin SDK

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@Elyniss Elyniss requested a review from chris13524 September 7, 2023 13:14
@Elyniss Elyniss linked an issue Sep 7, 2023 that may be closed by this pull request
@Elyniss Elyniss force-pushed the 45-update-cacao-identity branch from 5802d64 to e75981b Compare September 7, 2023 13:19
Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with notify server

@Elyniss Elyniss merged commit 54ce4be into main Sep 7, 2023
7 checks passed
@Elyniss Elyniss deleted the 45-update-cacao-identity branch September 7, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Cacao Identity
2 participants