Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 bucket behaviour is confusing / inconsistent #736

Open
TonyNoble opened this issue Apr 30, 2021 · 0 comments
Open

S3 bucket behaviour is confusing / inconsistent #736

TonyNoble opened this issue Apr 30, 2021 · 0 comments

Comments

@TonyNoble
Copy link

In MinioDataStore.java, fetching a file stored in S3/Minio (getMinioFile) has the following logic:

  • If the filename has no path elements, the default bucket name is prepended.
  • If the filename has one or more path elements, the bucket prefix is prepended

This does not account for instances where a file might have multiple path elements, but does not include the bucket name, leading to inconsistent behaviour - suggest that the bucket name and file path should be separate parameters in the method call. Then detecting which scenario would apply would be much simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant