diff --git a/CMakeLists.txt b/CMakeLists.txt index fca0ed89..c0ff004d 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,10 +1,10 @@ cmake_minimum_required(VERSION 3.16.0) project(pipedal - VERSION 1.2.34 + VERSION 1.2.36 DESCRIPTION "PiPedal Guitar Effect Pedal For Raspberry Pi" HOMEPAGE_URL "https://rerdavies.github.io/pipedal" ) -set (DISPLAY_VERSION "v1.2.34beta2") +set (DISPLAY_VERSION "v1.2.36beta2") set (CMAKE_INSTALL_PREFIX "/usr/") diff --git a/PiPedalCommon/src/RegDb.cpp b/PiPedalCommon/src/RegDb.cpp index b057a2a4..4bf9d814 100644 --- a/PiPedalCommon/src/RegDb.cpp +++ b/PiPedalCommon/src/RegDb.cpp @@ -177,7 +177,7 @@ struct PowerRule const char *filePaths[] = { - "/lib/firmware/regulatory.db", // bookworm, buster. + "/lib/firmware/regulatory.db", // bookworm, bullseye. "/usr/lib/crda/regulatory.bin" // previous versions?. }; diff --git a/README.md b/README.md index ba7c081f..32b159f2 100644 --- a/README.md +++ b/README.md @@ -1,12 +1,12 @@
-Download: v1.2.34 Beta2 +Download: v1.2.36 Beta3 Website: [https://rerdavies.github.io/pipedal](https://rerdavies.github.io/pipedal). -> NEW version 1.2.34 Beta2 release, providing support for Raspberry Pi OS Bookworm. See the [release notes](https://rerdavies.github.io/pipedal/ReleaseNotes) for details. +> NEW version 1.2.36 Beta3 release, providing support for Raspberry Pi OS Bookworm. See the [release notes](https://rerdavies.github.io/pipedal/ReleaseNotes) for details. Use your Raspberry Pi as a guitar effects pedal. Configure and control PiPedal with your phone or tablet. PiPedal running on a Raspberry Pi 4 provides stable super-low-latency audio via external USB audio devices, or internal Raspberry Pi audio hats. diff --git a/debian/control b/debian/control index 76dfce6c..20ceffd0 100644 --- a/debian/control +++ b/debian/control @@ -1,5 +1,5 @@ Architecture: arm64 -Depends: libstdc++6 (>= 9), libasound2 (>= 1.0.17), libc6 (>= 2.34), libgcc-s1 (>= 4.0), libjack-jackd2-0 (>= 1.9.10+20150825) | libjack-0.125, liblilv-0-0 (>= 0.22.0~dfsg0), libnl-3-200 (>= 3.2.7), libnl-genl-3-200 (>= 3.2.7), libstdc++6 (>= 11), libsystemd0, dnsmasq(>= 2.85) +Depends: libstdc++6 (>= 9), libasound2 (>= 1.0.17), libc6 (>= 2.34), libgcc-s1 (>= 4.0), libjack-jackd2-0 (>= 1.9.10+20150825) | libjack-0.125, liblilv-0-0 (>= 0.22.0~dfsg0), libnl-3-200 (>= 3.2.7), libnl-genl-3-200 (>= 3.2.7), libstdc++6 (>= 11), libsystemd0, dnsmasq(>= 2.85),lv2-dev(>=1.14) Description: IoT guitar effect for Raspberry Pi IoT guitar effect pedal for Raspberry Pi, with phone-friendly web interface. Homepage: https://github.com/rerdavies/pipedal diff --git a/docs/Installing.md b/docs/Installing.md index 9d159fa9..485d6cd7 100644 --- a/docs/Installing.md +++ b/docs/Installing.md @@ -13,17 +13,17 @@ page_icon: img/Install4.jpg Download the most recent Debian (.deb) package for your platform: -- [Raspberry Pi OS bookworm (64-bit) v1.2.34 Beta2](https://github.com/rerdavies/pipedal/releases/download/) -- [Ubuntu/Raspberry Pi OS buster (64-bit) v1.2.31](https://github.com/rerdavies/pipedal/releases/download/v1.1.31/pipedal_1.1.31_arm64.deb) +- [Raspberry Pi OS bookworm (64-bit) v1.2.36 Beta3](https://github.com/rerdavies/pipedal/releases/download/) +- [Ubuntu/Raspberry Pi OS bullseyeye (64-bit) v1.2.31](https://github.com/rerdavies/pipedal/releases/download/v1.1.31/pipedal_1.1.31_arm64.deb) -Version 1.2.34 has not yet been tested Ubuntu and Raspberry Pi OS buster. On these platforms, we recommend that you use version 1.1.31. +Version 1.2.36 has not yet been tested Ubuntu and Raspberry Pi OS bullseye. On these platforms, we recommend that you use version 1.1.31. Install the package by running ``` sudo apt update cd ~/Downloads - sudo dpkg -i pipedal_1.2.34_arm64.deb + sudo dpkg -i pipedal_1.2.36_arm64.deb ``` Adjust accordingly if you have downloaded v1.1.31. diff --git a/docs/ReleaseNotes.md b/docs/ReleaseNotes.md index 41759625..93f91754 100644 --- a/docs/ReleaseNotes.md +++ b/docs/ReleaseNotes.md @@ -1,4 +1,13 @@ # Release Notes +## Pipedal 1.2.36 Beta3 + +Fixes for the following issues: + +- Failure to open audio devices on reboot for devices that initialize slowly. +- TooB ML and Toob Neural Amp Modeller UI issues. +- Misbehavior with preset names after renaming a preset. +- Change default audio buffers to 64x3. +- Filtering not working in plugin selection dialog. ## PiPedal 1.2.34 Beta2 @@ -13,7 +22,7 @@ Fixes the following issues: ## PiPedal 1.2.33 Beta1 -This release provides compatibility with Raspberry Pi OS bookworm. If you are using Raspberry Pi OS buster, or Ubuntu 21.04, please use PiPedal v1.1.31 instead. +This release provides compatibility with Raspberry Pi OS bookworm. If you are using Raspberry Pi OS bullseye, or Ubuntu 21.04, please use PiPedal v1.1.31 instead. If you are using the Android client, you should make sure you are using the most recent version, which includes significant improvements to Wi-Fi Direct pairing. diff --git a/docs/SystemRequirements.md b/docs/SystemRequirements.md index 1dcb91d5..9352db5d 100644 --- a/docs/SystemRequirements.md +++ b/docs/SystemRequirements.md @@ -16,7 +16,7 @@ PiPedal has been tested on the following Operating Systems: Older versions of PiPedal (v1.1.31) have been tested on the following operating systems: * Ubuntu 21.04 or later, 64-bit -* Raspberry PI OS 64-bit Buster +* Raspberry PI OS 64-bit bullseye Compatibility testing on these OS's for current versions of PiPedal is ongoing. diff --git a/docs/download.md b/docs/download.md index 453b855e..d592bff9 100644 --- a/docs/download.md +++ b/docs/download.md @@ -4,17 +4,17 @@ Download the most recent Debian (.deb) package for your platform: -- Raspberry Pi OS Bookworm (64-bit) v1.2.34 Beta2 -- Ubuntu 21.04 or Raspberry Pi OS Buster (64-bit) v1.1.31 +- Raspberry Pi OS Bookworm (64-bit) v1.2.36 Beta3 +- Ubuntu 21.04 or Raspberry Pi OS bullseyeyeye (64-bit) v1.1.31 -v1.2.34 Beta1 is does not currently support Ubuntu 21.04, or older versions of Raspberry Pi OS. +v1.2.36 Beta3 is does not currently support Ubuntu 21.04, or older versions of Raspberry Pi OS. Install the package by running ``` sudo apt update cd ~/Downloads - sudo apt-get install ./pipedal_1.2.34_arm64.deb + sudo apt-get install ./pipedal_1.2.36_arm64.deb ``` Follow the instructions in [_Configuring PiPedal After Installation_](https://rerdavies.github.io/pipedal/Configuring.html) to complete the installation. diff --git a/docs/index.md b/docs/index.md index bca50830..d2c5c5c5 100644 --- a/docs/index.md +++ b/docs/index.md @@ -1,13 +1,13 @@ -v1.2.34 +v1.2.36   To download PiPedal, click [here](download.md). -> NEW version 1.2.34 Beta2 release. See the [release notes](https://rerdavies.github.io/pipedal/ReleaseNotes) for details. +> NEW version 1.2.36 Beta3 release. See the [release notes](https://rerdavies.github.io/pipedal/ReleaseNotes) for details. Use your Raspberry Pi as a guitar effects pedal. Configure and control PiPedal with your phone or tablet. diff --git a/lv2/aarch64/ToobAmp.lv2/CabIR.ttl b/lv2/aarch64/ToobAmp.lv2/CabIR.ttl index 0ebbf0e0..3353fa9d 100644 --- a/lv2/aarch64/ToobAmp.lv2/CabIR.ttl +++ b/lv2/aarch64/ToobAmp.lv2/CabIR.ttl @@ -88,7 +88,7 @@ cabir:impulseFile3 doap:license ; doap:maintainer ; lv2:minorVersion 0 ; - lv2:microVersion 31 ; + lv2:microVersion 36 ; rdfs:comment """ TooB Cab IR is a convolution-based guitar cabinet impulse response simulator. diff --git a/lv2/aarch64/ToobAmp.lv2/CabSim.ttl b/lv2/aarch64/ToobAmp.lv2/CabSim.ttl index 34d19e0e..89ce418d 100644 --- a/lv2/aarch64/ToobAmp.lv2/CabSim.ttl +++ b/lv2/aarch64/ToobAmp.lv2/CabSim.ttl @@ -49,7 +49,7 @@ toob:frequencyResponseVector doap:license ; doap:maintainer ; lv2:minorVersion 0 ; - lv2:microVersion 31 ; + lv2:microVersion 36 ; mod:brand "TooB"; mod:label "TooB CabSim"; diff --git a/lv2/aarch64/ToobAmp.lv2/ConvolutionReverb.ttl b/lv2/aarch64/ToobAmp.lv2/ConvolutionReverb.ttl index 603ddae6..2e5a2d93 100644 --- a/lv2/aarch64/ToobAmp.lv2/ConvolutionReverb.ttl +++ b/lv2/aarch64/ToobAmp.lv2/ConvolutionReverb.ttl @@ -51,7 +51,7 @@ toobimpulse:impulseFile doap:license ; doap:maintainer ; lv2:minorVersion 0 ; - lv2:microVersion 31 ; + lv2:microVersion 36 ; rdfs:comment """ Convolution reverb is a notoriously compute-intensive effect. If you are having performance issues, use the Max T control to constrain the length of the impulse file to diff --git a/lv2/aarch64/ToobAmp.lv2/ConvolutionReverbStereo.ttl b/lv2/aarch64/ToobAmp.lv2/ConvolutionReverbStereo.ttl index 31618abf..855bb7ba 100644 --- a/lv2/aarch64/ToobAmp.lv2/ConvolutionReverbStereo.ttl +++ b/lv2/aarch64/ToobAmp.lv2/ConvolutionReverbStereo.ttl @@ -49,7 +49,7 @@ toobimpulse:impulseFile doap:license ; doap:maintainer ; lv2:minorVersion 0 ; - lv2:microVersion 31 ; + lv2:microVersion 36 ; rdfs:comment """ diff --git a/lv2/aarch64/ToobAmp.lv2/InputStage.ttl b/lv2/aarch64/ToobAmp.lv2/InputStage.ttl index afd17e02..1531a558 100644 --- a/lv2/aarch64/ToobAmp.lv2/InputStage.ttl +++ b/lv2/aarch64/ToobAmp.lv2/InputStage.ttl @@ -65,7 +65,7 @@ inputStage:filterGroup doap:license ; doap:maintainer ; lv2:minorVersion 0 ; - lv2:microVersion 31 ; + lv2:microVersion 36 ; mod:brand "TooB"; mod:label "TooB Input"; diff --git a/lv2/aarch64/ToobAmp.lv2/SpectrumAnalyzer.ttl b/lv2/aarch64/ToobAmp.lv2/SpectrumAnalyzer.ttl index c663a037..0586574d 100644 --- a/lv2/aarch64/ToobAmp.lv2/SpectrumAnalyzer.ttl +++ b/lv2/aarch64/ToobAmp.lv2/SpectrumAnalyzer.ttl @@ -58,7 +58,7 @@ doap:license ; doap:maintainer ; lv2:minorVersion 0 ; - lv2:microVersion 31 ; + lv2:microVersion 36 ; rdfs:comment "TooB spectrum analyzer" ; mod:brand "TooB"; diff --git a/lv2/aarch64/ToobAmp.lv2/ToneStack.ttl b/lv2/aarch64/ToobAmp.lv2/ToneStack.ttl index 462252ab..de2c61e5 100644 --- a/lv2/aarch64/ToobAmp.lv2/ToneStack.ttl +++ b/lv2/aarch64/ToobAmp.lv2/ToneStack.ttl @@ -55,7 +55,7 @@ tonestack:eqGroup doap:license ; doap:maintainer ; lv2:minorVersion 0 ; - lv2:microVersion 31 ; + lv2:microVersion 36 ; uiext:ui ; diff --git a/lv2/aarch64/ToobAmp.lv2/ToobAmp.so.0 b/lv2/aarch64/ToobAmp.lv2/ToobAmp.so.0 index 10db7b54..e62ad8b8 120000 --- a/lv2/aarch64/ToobAmp.lv2/ToobAmp.so.0 +++ b/lv2/aarch64/ToobAmp.lv2/ToobAmp.so.0 @@ -1 +1 @@ -ToobAmp.so.1.1.31 \ No newline at end of file +ToobAmp.so.1.1.36 \ No newline at end of file diff --git a/lv2/aarch64/ToobAmp.lv2/ToobAmp.so.1.1.31 b/lv2/aarch64/ToobAmp.lv2/ToobAmp.so.1.1.31 index 3958e99a..28bc024a 100644 Binary files a/lv2/aarch64/ToobAmp.lv2/ToobAmp.so.1.1.31 and b/lv2/aarch64/ToobAmp.lv2/ToobAmp.so.1.1.31 differ diff --git a/lv2/aarch64/ToobAmp.lv2/ToobAmp.so.1.1.36 b/lv2/aarch64/ToobAmp.lv2/ToobAmp.so.1.1.36 new file mode 100644 index 00000000..bfbd5fb2 Binary files /dev/null and b/lv2/aarch64/ToobAmp.lv2/ToobAmp.so.1.1.36 differ diff --git a/lv2/aarch64/ToobAmp.lv2/ToobAmpUI.so b/lv2/aarch64/ToobAmp.lv2/ToobAmpUI.so index a294e6c5..95f5df59 100644 Binary files a/lv2/aarch64/ToobAmp.lv2/ToobAmpUI.so and b/lv2/aarch64/ToobAmp.lv2/ToobAmpUI.so differ diff --git a/lv2/aarch64/ToobAmp.lv2/ToobChorus.ttl b/lv2/aarch64/ToobAmp.lv2/ToobChorus.ttl index 8e65c734..ddeeff9c 100644 --- a/lv2/aarch64/ToobAmp.lv2/ToobChorus.ttl +++ b/lv2/aarch64/ToobAmp.lv2/ToobChorus.ttl @@ -40,7 +40,7 @@ doap:license ; doap:maintainer ; lv2:minorVersion 0 ; - lv2:microVersion 31 ; + lv2:microVersion 36 ; rdfs:comment """ Emulation of a Boss CE-2 Chorus. diff --git a/lv2/aarch64/ToobAmp.lv2/ToobDelay.ttl b/lv2/aarch64/ToobAmp.lv2/ToobDelay.ttl index 899b0bbb..c901bfe6 100644 --- a/lv2/aarch64/ToobAmp.lv2/ToobDelay.ttl +++ b/lv2/aarch64/ToobAmp.lv2/ToobDelay.ttl @@ -41,7 +41,7 @@ doap:license ; doap:maintainer ; lv2:minorVersion 0 ; - lv2:microVersion 31 ; + lv2:microVersion 36 ; rdfs:comment """ A straightforward no-frills digital delay. diff --git a/lv2/aarch64/ToobAmp.lv2/ToobFlanger.ttl b/lv2/aarch64/ToobAmp.lv2/ToobFlanger.ttl index c81f2afc..429851af 100644 --- a/lv2/aarch64/ToobAmp.lv2/ToobFlanger.ttl +++ b/lv2/aarch64/ToobAmp.lv2/ToobFlanger.ttl @@ -41,7 +41,7 @@ doap:license ; doap:maintainer ; lv2:minorVersion 0 ; - lv2:microVersion 31 ; + lv2:microVersion 36 ; rdfs:comment """ Emulation of a Boss BF-2 Flanger, based on circuit analysis and simulation of the original. diff --git a/lv2/aarch64/ToobAmp.lv2/ToobFlangerStereo.ttl b/lv2/aarch64/ToobAmp.lv2/ToobFlangerStereo.ttl index 4b58c27a..9f7eeb11 100644 --- a/lv2/aarch64/ToobAmp.lv2/ToobFlangerStereo.ttl +++ b/lv2/aarch64/ToobAmp.lv2/ToobFlangerStereo.ttl @@ -41,7 +41,7 @@ doap:license ; doap:maintainer ; lv2:minorVersion 0 ; - lv2:microVersion 31 ; + lv2:microVersion 36 ; rdfs:comment """ Digital emulation of a Boss BF-2 Flanger. diff --git a/lv2/aarch64/ToobAmp.lv2/ToobFreeverb.ttl b/lv2/aarch64/ToobAmp.lv2/ToobFreeverb.ttl index 27defcce..6ae6c9fd 100644 --- a/lv2/aarch64/ToobAmp.lv2/ToobFreeverb.ttl +++ b/lv2/aarch64/ToobAmp.lv2/ToobFreeverb.ttl @@ -41,7 +41,7 @@ doap:license ; doap:maintainer ; lv2:minorVersion 0 ; - lv2:microVersion 31 ; + lv2:microVersion 36 ; rdfs:comment """ Toob Freeverb is an Lv2 implementation of the famous Freeverb reverb effect. FreeVerb delivers a well-balanced reverb with very little tonal coloration. diff --git a/lv2/aarch64/ToobAmp.lv2/ToobML.ttl b/lv2/aarch64/ToobAmp.lv2/ToobML.ttl index 7713756c..2c6ad9ae 100644 --- a/lv2/aarch64/ToobAmp.lv2/ToobML.ttl +++ b/lv2/aarch64/ToobAmp.lv2/ToobML.ttl @@ -14,6 +14,8 @@ @prefix param: . @prefix work: . @prefix pg: . +@prefix pipedal_ui: . +@prefix toob: . @prefix atom: . @prefix patch: . @@ -55,7 +57,7 @@ toobml:sagGroup doap:license ; doap:maintainer ; lv2:minorVersion 0 ; - lv2:microVersion 31 ; + lv2:microVersion 36 ; rdfs:comment """ The TooB ML Amplifier plugin provides emulation of a variety of amplifiers and overdrive pedals that are implemented using neural-network-based machine learning models of real amplifiers. @@ -450,4 +452,29 @@ and uses model files from the GuitarML Neural Pi project (https://github.com/Gui lv2:extensionData uiext:resize ; lv2:extensionData uiext:idleInterface; lv2:requiredFeature uiext:idleInterface ; + patch:writable + ; . + + + pipedal_ui:ui . + + + + a pipedal_ui:ui ; + pipedal_ui:frequencyPlot + [ + lv2:index 8 ; + pg:group toobml:filterGroup ; + + pipedal_ui:patchProperty toob:frequencyResponseVector; + pipedal_ui:xLeft 30 ; + pipedal_ui:xRight 22050 ; + pipedal_ui:yTop 10 ; + pipedal_ui:yBottom -35 ; + pipedal_ui:xLog 1 ; + pipedal_ui:yDb 1 ; + pipedal_ui:width 160 ; + ] + . + diff --git a/lv2/aarch64/ToobAmp.lv2/ToobNeuralAmpModeler.ttl b/lv2/aarch64/ToobAmp.lv2/ToobNeuralAmpModeler.ttl index 088dd091..0141fa6e 100644 --- a/lv2/aarch64/ToobAmp.lv2/ToobNeuralAmpModeler.ttl +++ b/lv2/aarch64/ToobAmp.lv2/ToobNeuralAmpModeler.ttl @@ -58,7 +58,7 @@ toobNam:eqGroup doap:license ; doap:maintainer ; lv2:minorVersion 0 ; - lv2:microVersion 31 ; + lv2:microVersion 36 ; rdfs:comment """ A port of Steven Atkinson's Neural Amp Modeler to LV2. @@ -338,7 +338,7 @@ toobNam:ui pipedal_ui:frequencyPlot [ pipedal_ui:patchProperty toobNam:FrequencyResponse; - lv2:index 7 ; + lv2:index 9 ; pg:group toobNam:eqGroup ; pipedal_ui:width: 200; ] diff --git a/lv2/aarch64/ToobAmp.lv2/ToobTuner.ttl b/lv2/aarch64/ToobAmp.lv2/ToobTuner.ttl index 7e979867..2296242b 100644 --- a/lv2/aarch64/ToobAmp.lv2/ToobTuner.ttl +++ b/lv2/aarch64/ToobAmp.lv2/ToobTuner.ttl @@ -40,7 +40,7 @@ doap:license ; doap:maintainer ; lv2:minorVersion 0 ; - lv2:microVersion 31 ; + lv2:microVersion 36 ; rdfs:comment """ TooB Tuner is a chromatic guitar tuner. """ ; diff --git a/react/public/var/config.json b/react/public/var/config.json index bf8d4ce2..80d344af 100644 --- a/react/public/var/config.json +++ b/react/public/var/config.json @@ -1,5 +1,5 @@ { - "socket_server_port": 8080, + "socket_server_port": 80, "socket_server_address": "*", "debug": true, "max_upload_size": 1048576, diff --git a/react/src/PluginOutputControl.tsx b/react/src/PluginOutputControl.tsx index 3b5e8abf..2ed160ae 100644 --- a/react/src/PluginOutputControl.tsx +++ b/react/src/PluginOutputControl.tsx @@ -353,7 +353,7 @@ const PluginOutputControl =
-
+
diff --git a/src/AlsaDriver.cpp b/src/AlsaDriver.cpp index f08e725b..09a79660 100644 --- a/src/AlsaDriver.cpp +++ b/src/AlsaDriver.cpp @@ -1961,7 +1961,7 @@ namespace pipedal for (int retry = 0; retry < 15; ++retry) { err = snd_pcm_open(&playbackHandle, alsaDeviceName.c_str(), SND_PCM_STREAM_PLAYBACK, SND_PCM_NONBLOCK); - if (err == -EBUSY) + if (err < 0) // field report of a device that is present, but won't immediately open. { sleep(1); continue; diff --git a/src/ConfigMain.cpp b/src/ConfigMain.cpp index cf4fd778..13c1d7f0 100644 --- a/src/ConfigMain.cpp +++ b/src/ConfigMain.cpp @@ -603,12 +603,19 @@ void SetVarPermissions( using namespace std::filesystem; try { if (fs::exists(path)) { - + chown(path.c_str(),uid,gid); if (fs::is_directory(path)) { fs::permissions(path, directoryPermissions, fs::perm_options::replace); for (const auto& entry : fs::recursive_directory_iterator(path)) { + cout << " " << entry.path() << endl; + + if (chown(entry.path().c_str(),uid,gid) != 0) + { + std::cout << "Error: failed to set ownership of file " << entry.path() << std::endl; + } + try { - if (fs::is_directory(entry)) + if (fs::is_directory(entry.path())) { fs::permissions(entry.path(), directoryPermissions, fs::perm_options::replace); } else { @@ -618,15 +625,11 @@ void SetVarPermissions( { std::cout << "Error: failed to set permissions on file " << entry.path() << std::endl; } - if (chown(path.c_str(),uid,gid) != 0) - { - std::cout << "Error: failed to set ownership of file " << entry.path() << std::endl; - } } } else { fs::permissions(path,filePermissions, fs::perm_options::replace); - chown(path.c_str(),uid,gid); + } } else { std::cout << "Error: Path does not exist: " << path << std::endl; diff --git a/src/JackServerSettings.hpp b/src/JackServerSettings.hpp index 50ee49ce..6d27282b 100644 --- a/src/JackServerSettings.hpp +++ b/src/JackServerSettings.hpp @@ -34,7 +34,7 @@ namespace pipedal std::string alsaDevice_; uint64_t sampleRate_ = 0; uint32_t bufferSize_ = 64; - uint32_t numberOfBuffers_ = 2; + uint32_t numberOfBuffers_ = 3; public: JackServerSettings(); diff --git a/src/PiPedalModel.cpp b/src/PiPedalModel.cpp index a001da1b..59c0bc2b 100644 --- a/src/PiPedalModel.cpp +++ b/src/PiPedalModel.cpp @@ -142,7 +142,11 @@ void PiPedalModel::Init(const PiPedalConfiguration &configuration) this->systemMidiBindings = storage.GetSystemMidiBindings(); - this->jackServerSettings.ReadJackDaemonConfiguration(); +#if JACK_HOST + this->jackConfiguration = this->jackConfiguration.JackInitialize(); +#else + this->jackServerSettings = storage.GetJackServerSettings(); +#endif } void PiPedalModel::LoadLv2PluginInfo() @@ -945,6 +949,11 @@ bool PiPedalModel::RenamePreset(int64_t clientId, int64_t instanceId, const std: if (storage.RenamePreset(instanceId, name)) { this->FirePresetsChanged(clientId); + if (storage.GetCurrentPresetId() == instanceId) + { + this->pedalboard.name(name); + this->FirePedalboardChanged(-1); + } return true; } else diff --git a/src/main.cpp b/src/main.cpp index 2f9b44ea..9b865fa1 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -701,7 +701,10 @@ int main(int argc, char *argv[]) // wait up to 15 seconds for the midi device to come online. auto devices = model.GetAlsaDevices(); bool found = false; - if (!HasAlsaDevice(devices, serverSettings.GetAlsaInputDevice())) + if (HasAlsaDevice(devices, serverSettings.GetAlsaInputDevice())) + { + Lv2Log::info(SS("Found ALSA device " << serverSettings.GetAlsaInputDevice() << ".")); + } else { for (int i = 0; i < 5; ++i) { @@ -727,6 +730,9 @@ int main(int argc, char *argv[]) Lv2Log::info(SS("ALSA device " << serverSettings.GetAlsaInputDevice() << " not found.")); } } + } else { + Lv2Log::info("No ALSA device selected."); + } // pre-cache device info before we let audio services run. diff --git a/todo.txt b/todo.txt index 385b5a92..2e0b1e4e 100644 --- a/todo.txt +++ b/todo.txt @@ -1,16 +1,13 @@ -x group EQ congrols on Toob Preamp. --x Bug with FLAC libs in debian package. --x check default presets. --x check Toob power stage is installed. -X check FLAC decode. +- make sure lv2-dev shows up in packaging. Make sure dhcpcd shows up in packaging +- Toob nam input VU is not working. +- x TooB NAM: dbVu telltale is zero0. +- x TooB NAM: bass [] mid trebble. +- X check FLAC decode. - make app use the same theme settings as the website. - BUG: gcs when we have an animated output control - Shutdown/reboot midi bindings - versioning. -- sample launch.json file. -- add tubeamp mods to release notes. - do we want to take a second crack at establishin multi-p2p connections with the driver_param? -- merge ToobML gain control fixes AFTER we do the commit so we can enforce formatting. sudo apt install libsdbus-c++-dev libnm-dev