Skip to content

Commit

Permalink
Tweak profiling scopes (#8188)
Browse files Browse the repository at this point in the history
* [x] ok
  • Loading branch information
emilk authored Nov 20, 2024
1 parent cf4c76c commit 1ad3042
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion crates/store/re_chunk_store/src/writes.rs
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ impl ChunkStore {
return Ok(Vec::new());
};

re_tracing::profile_function!(format!("{}", row_id_range.0));
re_tracing::profile_function!();

self.insert_id += 1;

Expand Down
10 changes: 6 additions & 4 deletions crates/store/re_entity_db/src/entity_db.rs
Original file line number Diff line number Diff line change
Expand Up @@ -390,8 +390,12 @@ impl EntityDb {
.filter(|event| event.kind == ChunkStoreDiffKind::Deletion)
.map(|event| event.chunk.entity_path().clone())
.collect();
self.tree
.on_store_deletions(&engine, &entity_paths_with_deletions, &store_events);

{
re_tracing::profile_scope!("on_store_deletions");
self.tree
.on_store_deletions(&engine, &entity_paths_with_deletions, &store_events);
}

// We inform the stats last, since it measures e2e latency.
self.stats.on_events(&store_events);
Expand Down Expand Up @@ -543,8 +547,6 @@ impl EntityDb {
mut engine: StorageEngineWriteGuard<'_>,
store_events: &[ChunkStoreEvent],
) {
re_tracing::profile_function!();

engine.cache().on_events(store_events);
times_per_timeline.on_events(store_events);
time_histogram_per_timeline.on_events(store_events);
Expand Down
2 changes: 0 additions & 2 deletions crates/store/re_entity_db/src/entity_tree.rs
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,6 @@ impl EntityTree {
entity_paths_with_deletions: &IntSet<EntityPath>,
events: &[ChunkStoreEvent],
) {
re_tracing::profile_function!();

// We don't actually use the events for anything, we just want to
// have a direct dependency on the chunk store which must have
// produced them by the time this function was called.
Expand Down

0 comments on commit 1ad3042

Please sign in to comment.