add wedowind example #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update smarteole_example.ipynb fix issue, CACHE_SUBDIR is missing if data has never been downloaded * Update smarteole_example.ipynb fix ruff issue * Update smarteole_example.ipynb try to fix ruff issue * fix issues after updating ruff * Fix plotconfig mkdir (#16) * remove make_plots_dir * Update main_analysis.py fix missing dir issue * bump version * Update smarteole_example.ipynb * Update smarteole_example.ipynb filter SmallSampleWarning * Update smarteole_example.ipynb fix ruff issue * Create wind-up uplift validation methodology.pdf * Cleanup requests dependency and move to examples group (#19) * Cleanup requests dependency and move to examples group * Jupyter group moved to examples and all group added * Update pyproject.toml define all using other groups --------- Co-authored-by: Alex Clerc <alex.clerc@res-group.com> * support Python 3.9 (#17) * try Python 3.9 in workflow * Update lint-and-test.yaml * try from __future__ import annotations * Update conftest.py * add eval-type-backport * more from __future__ import annotations * remove TypeAlias * replace zip with strict_zip * ignore 3.9 mypy issues * fix bug in backporting.py * Update lint-and-test.yaml * Update lint-and-test.yaml * Update pyproject.toml move types-requests to dev * Update smarteole_example.ipynb * Update smarteole_example.ipynb * Update smarteole_example.ipynb * Define supported python (#23) * add badge to README * Update pyproject.toml * Update lint-and-test.yaml * update classifiers * Update lint-and-test.yaml * Update README.md * Update smarteole_example.ipynb * Update lint-and-test.yaml * Update README.md * Update smarteole_example.ipynb * fix methodology link --------- Co-authored-by: Gorkem Kacar <139143704+izofat@users.noreply.github.com>
Organise code into function to improve readability and demonstrate usage in ipynb
samuelwnaylor
force-pushed
the
wedowind-example
branch
2 times, most recently
from
754b5f6
to
a2d75db
Compare
- Support both Pitch Angle Pair and Vortex Generator Pair WeDoWind datasets - Support not clipping rated power - Improve readability and replace some hard-coded column name strings
samuelwnaylor
force-pushed
the
wedowind-example
branch
from
a2d75db
to
accd4d6
Compare
samuelwnaylor
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Looks good, thanks @aclerc !
Some of the abbreviated names could be elaborated on (perhaps using the full name instead) to improve readability.
| ] | ||
| ] | ||
|
|
||
| def _convert_frc_cols_to_pct(input_df: pd.DataFrame, dp: int = 1) -> pd.DataFrame: |
There was a problem hiding this comment.
Nice private function here. I like longer more descriptive names for readability, e.g. _convert_fraction_cols_to_percentage, but that is only a personal preference
| ) | ||
| print_df["mean power toggle on"] = print_df["mean power toggle on"].round(0).astype("int64") | ||
| print_df_for_tabulate = ( | ||
| print_df[["turbine", "reference", "energy uplift", "uplift P95", "uplift P5", "valid hours toggle on"]] |
There was a problem hiding this comment.
Could put these hard-coded strings into an Enum class and use that here and above in the renaming columns.
| showindex=False, | ||
| ) | ||
| print(results_table) | ||
| return print_df |
There was a problem hiding this comment.
It feels like maybe the naming of results_table and print_df could be swapped? Because currently results_table is being printed and print_df being returned.
| showindex=False, | ||
| ) | ||
| print(results_table) | ||
| print_df = format_and_print_results_table(results_per_test_ref_df, print_small_table=print_small_table) |
| ref_wd_filter: list[int] = Field( | ||
| description="directions to include in power performance analysis", default=[0, 360] | ||
| ) | ||
| clip_rated_power_pp: bool |
There was a problem hiding this comment.
We could add a description to this attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
examples/wedowind_example.pyfor the WeDoWind Turbine Performance Quantification Collaboration.This PR also adds two new settings to
WindUpConfigwhich can activate new logic inwind_up/pp_analysis.pyto help with upgrades affecting rated power