-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quantify wind speed shift #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a high level this looks very good. I like the new ops_curve_shift.py
module and appreciate the thorough testing of it. Could you please re-run the smarteole notebook as part of this PR? This way the PR will include a real-world example of the new wind speed drift calculation for sanity checking.
847827a
to
335620c
Compare
Addressed in commit 6ff04f8 |
af5f8c6
to
6ff04f8
Compare
4263fe0
to
05b0c19
Compare
I've added the running and maintenance of
[UPDATE] The Smarteole example notebook is executed in the |
b5832be
to
7eca5a8
Compare
7eca5a8
to
8362e05
Compare
8362e05
to
ae41ed8
Compare
ae41ed8
to
444e8bd
Compare
ae6fce2
to
59ae437
Compare
699ce81
to
a046562
Compare
c085f92
to
e9ae4ae
Compare
smarteole_example.ipynb updated by GitHubAction
e9ae4ae
to
156b644
Compare
In similar way that power curve, rpm and pitch shifts are already calculated, the change in this PR adds wind speed shift to the calculated ops curve shifts.
A refactor on the ops curve shift functionality was performed as part of this PR to improve readability and ease of adding further shift calculations if required in future.