Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantify wind speed shift #42

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Commits on Nov 14, 2024

  1. refactor: move ops curve shift calcs and reduce complexity of functions

    - Moves Operational Curve shift calculations into their own module
    - Refactor into separate curve specific functions
      (with underlying more generic private functions)
    
    This change improves readability and ease of adding further curve shift
    calculations.
    samuelwnaylor committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f1093b2 View commit details
    Browse the repository at this point in the history
  2. feat: add function to quantify wind speed shift

    In similar way that power curve, rpm and pitch shifts are already
    calculated, this change adds wind speed shift to the ops curve shift
    module
    samuelwnaylor committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    699be85 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. refactor: log the curve shift value sign in the warning message

    Display the sign (+/-) of the curve shift value in the log warning
    message for clarity of the actual shift rather than just displaying the
    abs() value that is used when determining whether to raise a log warning
    samuelwnaylor committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    4fac54c View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. address pr comments

    samuelwnaylor committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    173f074 View commit details
    Browse the repository at this point in the history