Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async serializer? #2165

Open
b-maslennikov opened this issue Jan 12, 2024 · 2 comments
Open

Async serializer? #2165

b-maslennikov opened this issue Jan 12, 2024 · 2 comments

Comments

@b-maslennikov
Copy link

Would it be possible to add support of async serializer?

System.Text.Json IAsyncEnumerable serialization
If you want to serialize IAsyncEnumerable in net6+ app you need to use JsonSerializer.SerializeAsync() method
IRestSerializer does not allow to await inside Serializer() as it's synchronious method.
Temporary solution - using GetAwaiter().GetResult() - but this approach doesn't offer "true" async support

@alexeyzimarev
Copy link
Member

Yes, I think it's a good idea

@alexeyzimarev
Copy link
Member

I tried to do it but getting full advantage of async serialisation requires reconsidering the way serialisation works in general in RestSharp. For example, SerializeAsync and DeserializeAsync of JsonSerializer work with streams, and RestSharp works with strings. So, the whole thing needs to be converted to work with streams instead of strings.

Of course, it is trivial to change the signature for interfaces and all the implementations. Would this help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants