-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve RecheckSeleniumAdapter#convert( Object ) performance #166
Labels
enhancement
New feature or request
Comments
This simple test (which uses class GoogleIT {
WebDriver driver;
Recheck re;
@BeforeEach
void setUp() throws Exception {
driver = new ChromeDriver();
re = new RecheckImpl();
}
@Test
void test() throws Exception {
re.startTest();
driver.get( "https://policies.google.com/privacy?hl=de&gl=de" );
final long start = System.currentTimeMillis();
re.check( driver, "german-privacy-policy" );
final long end = System.currentTimeMillis();
System.out.println( "check took " + TimeUnit.MILLISECONDS.toSeconds( end - start ) + " seconds" );
re.capTest();
}
@AfterEach
void tearDown() throws Exception {
driver.quit();
re.cap();
}
} This single check takes up to 14 seconds on my machine. |
12 seconds for https://en.wikipedia.org/wiki/President_of_the_United_States. |
We need to do some more investigation on where the actual performance bottleneck is.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Conversion sometimes takes up to 5 or more seconds. It would be helpful (for surili as well) if we could somehow improve the conversion performance.
The text was updated successfully, but these errors were encountered: