Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Encoding field to PETFile #31

Open
pixeldesu opened this issue Jun 8, 2019 · 0 comments
Open

Add Encoding field to PETFile #31

pixeldesu opened this issue Jun 8, 2019 · 0 comments
Labels
feature request New feature or request PangLib.PET Issues regarding PangLib.PET

Comments

@pixeldesu
Copy link
Member

Currently, string encoding is all over the place for Puppet files, early code iterations use Encoding.UTF8, later ones use Encoding.ASCII.

To solve and improve this, add a Encoding (with Encoding.ASCII as a default) field to PETFile and pass the encoding to helpers where necessary.
@pixeldesu pixeldesu added feature request New feature or request PangLib.PET Issues regarding PangLib.PET labels Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request PangLib.PET Issues regarding PangLib.PET
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixeldesu