Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VImg & VPictureSource: wrong generated imagesrcset during preload link #85

Closed
timothejoubert opened this issue Sep 27, 2024 · 1 comment

Comments

@timothejoubert
Copy link
Contributor

timothejoubert commented Sep 27, 2024

Modifier options seem to be missing in the imagesrcset preload link.

Exemple above with this input:

<VRoadizMedia
    v-if="media"
    :document="media"
    :class="$style.media"
    :image="{ loading: 'eager', preload: true }"
    :video="{ background: true, width: '1344', height: '683' }"
>
    <VPictureSource
        sizes="xs:96vw sm:96vw md:96vw"
        media="(max-width: 767px)"
        :modifiers="{ crop: '343x356' }"
    />
    <VPictureSource
        sizes="lg:96vw vl:96vw xl:96vw xxl:96vw hd:96vw qhd:96vw"
        :modifiers="{ crop: '1344x683' }"
    />
</VRoadizMedia>
@timothejoubert
Copy link
Contributor Author

Can't reproduce on starter, need to be check on specific projet.

But this preload link is usefull ? Browser seem to ignore them if image isn't used on first load forum issue
image

@timothejoubert timothejoubert closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant