diff --git a/.github/workflows/Dockerfile b/.github/workflows/Dockerfile index 5097b1c46..ab6a31d5f 100644 --- a/.github/workflows/Dockerfile +++ b/.github/workflows/Dockerfile @@ -21,6 +21,8 @@ RUN --mount=type=bind,target=/tmp/rviz \ apt-get -q install --no-install-recommends -y \ # Some basic requirements wget git sudo \ + # Qt6 packages for Jammy + $(test "$ROS_DISTRO" = "one" && echo "qt6-base-dev qt6-base-dev-tools libqt6opengl6-dev") \ # Preferred build tools clang clang-format-12 clang-tidy clang-tools ccache && \ # diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index b649be74f..5e15f764c 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -16,16 +16,23 @@ jobs: distro: [noetic, jammy] ogre: ["1.9", "1.12"] include: + - qt: 5 + cxxflags: -Werror - distro: noetic ogre: 1.9 env: CLANG_TIDY: true + - distro: jammy + ogre: 1.12 + qt: 6 + cxxflags: env: - CXXFLAGS: "-DRVIZ_DEPRECATE_QT4_SLOTS -Werror -Wall -Wextra -Wwrite-strings -Wunreachable-code -Wpointer-arith -Wredundant-decls -Wno-strict-aliasing -Wno-sign-compare" + CXXFLAGS: "-DRVIZ_DEPRECATE_QT4_SLOTS -Wall -Wextra -Wwrite-strings -Wunreachable-code -Wpointer-arith -Wredundant-decls -Wno-strict-aliasing -Wno-sign-compare ${{ matrix.cxxflags}}" UPSTREAM_WORKSPACE: ${{ matrix.distro != 'jammy' && 'github:rhaschke/python_qt_binding#silent-external-warnings' || '' }} AFTER_INSTALL_TARGET_DEPENDENCIES: apt install -qq -y libogre-${{ matrix.ogre }}-dev CATKIN_LINT: true + CMAKE_ARGS: -DRVIZ_QT_VERSIONS="${{ matrix.qt }}" CCACHE_DIR: ${{ github.workspace }}/.ccache BASEDIR: /home/runner/work DOCKER_IMAGE: rhaschke/ici:rviz-${{ matrix.distro }}-ros @@ -33,7 +40,7 @@ jobs: # perform full clang-tidy check only on manual trigger (workflow_dispatch), PRs do check changed files, otherwise nothing CLANG_TIDY_BASE_REF: ${{ github.event_name != 'workflow_dispatch' && (github.base_ref || github.ref) || '' }} - name: "${{ matrix.distro }} • ogre ${{ matrix.ogre }}${{ matrix.env.CLANG_TIDY && (github.event_name != 'workflow_dispatch' && ' • clang-tidy (delta)' || ' • clang-tidy (all)') || '' }}" + name: "${{ matrix.distro }} • ogre ${{ matrix.ogre }} • Qt ${{ matrix.qt }}${{ matrix.env.CLANG_TIDY && (github.event_name != 'workflow_dispatch' && ' • clang-tidy (delta)' || ' • clang-tidy (all)') || '' }}" runs-on: ubuntu-latest steps: - uses: actions/checkout@v3