-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the language to JSON payload of ASR and NLU topics #11
Comments
Good idea, I hope to have more spare time to be more actively involved :) |
@synesthesiam I'm testing my Dutch Rhasspy setup and I see "lang": null in the intent messages, is this an implementation error or are the language attributes not yet set by the dialogue manager? |
Right now, the Whose job do you think it is to set the language? Should it be hinted at by the wake word? Or is the ASR responsible? |
The ASR seems to me the most sensible choice. Wake words could be language-independent, and a wake word isn't necessary (if you start a session with a button). But it should also work if you enter text in the web interface for intent recognition. |
I have been thinking about this. The logic could be: every service in the chain of messages looks at the currently set An alternative way could be that services are able to override non-null language attributes with another non-null language attribute (e.g. the hotword service sets the language to Dutch but the ASR overrides it to English), but I don't think this makes much sense, and it could complicate matters. |
Yes, this is what I was thinking too (propagate if null, optionally set otherwise)! If we let the wake word service set |
This will be in 2.5.10 |
To create multilingual Rhasspy apps that are able to react to intents in the right language, they should know what language the original spoken command was in. I propose to add a
lang
attribute to the JSON payload of the following MQTT topics:See rhasspy/rhasspy-hermes-app#1 for the motivation for this change.
The ASR and NLU components should then fill in this
lang
attribute with the right language of the user's profile.The text was updated successfully, but these errors were encountered: