Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good friday US holiday not added in calendar #129

Open
tomassar opened this issue Jun 25, 2024 · 2 comments
Open

Good friday US holiday not added in calendar #129

tomassar opened this issue Jun 25, 2024 · 2 comments

Comments

@tomassar
Copy link

tomassar commented Jun 25, 2024

Hi there, just a quick question, why isnt the Good Friday holiday added in the US holidays?

var GoodFriday = &cal.Holiday{
	Name:  "Good Friday",
	Month: time.March,
	Day:   29,
	Func:  cal.CalcDayOfMonth,
}

I can easily submit a PR but before I need to know if there's a good reason to ignore it.

@rickar
Copy link
Owner

rickar commented Jun 26, 2024

There isn’t a technical reason or anything. So far I only added federal holidays where most businesses close because that’s all I needed personally. I assumed other religious holidays and special days would be added eventually. Feel free to add it.

@tomassar
Copy link
Author

Got it, will submit a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants