From ee99fd3377f75e9889b5b34c55bfb67fe44b2c9a Mon Sep 17 00:00:00 2001 From: Ruben Das Date: Thu, 14 Dec 2023 16:15:25 +0100 Subject: [PATCH 1/2] =?UTF-8?q?refactor(se=5Fholidays):=20F=C3=B6rsta=20Ma?= =?UTF-8?q?j=20->=20F=C3=B6rsta=20maj?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit All month names are written with a small initial letter in Swedish. --- v2/se/se_holidays.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2/se/se_holidays.go b/v2/se/se_holidays.go index a5219d6..571c6fb 100644 --- a/v2/se/se_holidays.go +++ b/v2/se/se_holidays.go @@ -27,7 +27,7 @@ var ( AnnandagPask = aa.EasterMonday.Clone(&cal.Holiday{Name: "Annandag påsk", Type: cal.ObservancePublic}) // ForstaMaj represents Labour Day on 1-May - ForstaMaj = aa.WorkersDay.Clone(&cal.Holiday{Name: "Första Maj", Type: cal.ObservancePublic}) + ForstaMaj = aa.WorkersDay.Clone(&cal.Holiday{Name: "Första maj", Type: cal.ObservancePublic}) // KristiHimmelfardsdag represents Ascension Day on the 39th day after Easter KristiHimmelfardsdag = aa.AscensionDay.Clone(&cal.Holiday{Name: "Kristi himmelsfärds dag", Type: cal.ObservancePublic}) From bcd4284cd3b35a23e4edace0d47d138b9e9adb09 Mon Sep 17 00:00:00 2001 From: Ruben Das Date: Thu, 14 Dec 2023 16:18:15 +0100 Subject: [PATCH 2/2] =?UTF-8?q?refactor(se=5Fholidays):=20himmelsf=C3=A4rd?= =?UTF-8?q?s=20dag=20->=20himmelsf=C3=A4rdsdag?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is one word: https://sv.wikipedia.org/wiki/Kristi_himmelsf%C3%A4rdsdag, which we already can see in the variable naming since it's not called KristiHimmelfardsDag. Also adding a missing S to the variable after Himmel. --- v2/se/se_holidays.go | 6 +++--- v2/se/se_holidays_test.go | 18 +++++++++--------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/v2/se/se_holidays.go b/v2/se/se_holidays.go index 571c6fb..a4e1796 100644 --- a/v2/se/se_holidays.go +++ b/v2/se/se_holidays.go @@ -29,8 +29,8 @@ var ( // ForstaMaj represents Labour Day on 1-May ForstaMaj = aa.WorkersDay.Clone(&cal.Holiday{Name: "Första maj", Type: cal.ObservancePublic}) - // KristiHimmelfardsdag represents Ascension Day on the 39th day after Easter - KristiHimmelfardsdag = aa.AscensionDay.Clone(&cal.Holiday{Name: "Kristi himmelsfärds dag", Type: cal.ObservancePublic}) + // KristiHimmelsfardsdag represents Ascension Day on the 39th day after Easter + KristiHimmelsfardsdag = aa.AscensionDay.Clone(&cal.Holiday{Name: "Kristi himmelsfärdsdag", Type: cal.ObservancePublic}) // Pingstdagen represents Pentecost Sunday on the 49th day after Easter Pingstdagen = aa.Pentecost.Clone(&cal.Holiday{Name: "Pingstdagen", Type: cal.ObservancePublic}) @@ -108,7 +108,7 @@ var ( Langfredagen, AnnandagPask, ForstaMaj, - KristiHimmelfardsdag, + KristiHimmelsfardsdag, Nationaldagen, Midsommarafton, Midsommardagen, diff --git a/v2/se/se_holidays_test.go b/v2/se/se_holidays_test.go index 3afed90..a291af2 100644 --- a/v2/se/se_holidays_test.go +++ b/v2/se/se_holidays_test.go @@ -80,15 +80,15 @@ func TestHolidays(t *testing.T) { {ForstaMaj, 2022, d(2022, 5, 1), d(2022, 5, 1)}, {ForstaMaj, 2023, d(2023, 5, 1), d(2023, 5, 1)}, - {KristiHimmelfardsdag, 2015, d(2015, 5, 14), d(2015, 5, 14)}, - {KristiHimmelfardsdag, 2016, d(2016, 5, 5), d(2016, 5, 5)}, - {KristiHimmelfardsdag, 2017, d(2017, 5, 25), d(2017, 5, 25)}, - {KristiHimmelfardsdag, 2018, d(2018, 5, 10), d(2018, 5, 10)}, - {KristiHimmelfardsdag, 2019, d(2019, 5, 30), d(2019, 5, 30)}, - {KristiHimmelfardsdag, 2020, d(2020, 5, 21), d(2020, 5, 21)}, - {KristiHimmelfardsdag, 2021, d(2021, 5, 13), d(2021, 5, 13)}, - {KristiHimmelfardsdag, 2022, d(2022, 5, 26), d(2022, 5, 26)}, - {KristiHimmelfardsdag, 2023, d(2023, 5, 18), d(2023, 5, 18)}, + {KristiHimmelsfardsdag, 2015, d(2015, 5, 14), d(2015, 5, 14)}, + {KristiHimmelsfardsdag, 2016, d(2016, 5, 5), d(2016, 5, 5)}, + {KristiHimmelsfardsdag, 2017, d(2017, 5, 25), d(2017, 5, 25)}, + {KristiHimmelsfardsdag, 2018, d(2018, 5, 10), d(2018, 5, 10)}, + {KristiHimmelsfardsdag, 2019, d(2019, 5, 30), d(2019, 5, 30)}, + {KristiHimmelsfardsdag, 2020, d(2020, 5, 21), d(2020, 5, 21)}, + {KristiHimmelsfardsdag, 2021, d(2021, 5, 13), d(2021, 5, 13)}, + {KristiHimmelsfardsdag, 2022, d(2022, 5, 26), d(2022, 5, 26)}, + {KristiHimmelsfardsdag, 2023, d(2023, 5, 18), d(2023, 5, 18)}, {Pingstdagen, 2015, d(2015, 5, 24), d(2015, 5, 24)}, {Pingstdagen, 2016, d(2016, 5, 15), d(2016, 5, 15)},