Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onApprovalCompleted cannot be called back #28

Closed
damahaokaixin opened this issue Jul 7, 2024 · 2 comments
Closed

onApprovalCompleted cannot be called back #28

damahaokaixin opened this issue Jul 7, 2024 · 2 comments

Comments

@damahaokaixin
Copy link

Please check it

onApprovalCompleted cannot be called back because isApprovalCompleted will always return false.


file path src/Traits/Approvable.php isApprovalCompleted ()

`

$registeredSteps = collect($this->approvalStatus->steps ?? []);

change to the following line

$registeredSteps = collect($this->approvalStatus()->first()->steps ?? []);

`

Should I update the $this->approvalStatus property immediately after executing the $this->updateStatus($nextStep->id, $approval) method?

@ringunger
Copy link
Contributor

Hello @damahaokaixin
Can you please update to v 1.0.8 and let me know if the issue is fixed?

@ringunger
Copy link
Contributor

Closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants