-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onApprovalCompleted cannot be called back #28
Comments
Hello @damahaokaixin |
Closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please check it
onApprovalCompleted cannot be called back because isApprovalCompleted will always return false.
file path src/Traits/Approvable.php isApprovalCompleted ()
`
$registeredSteps = collect($this->approvalStatus->steps ?? []);
change to the following line
$registeredSteps = collect($this->approvalStatus()->first()->steps ?? []);
`
Should I update the $this->approvalStatus property immediately after executing the $this->updateStatus($nextStep->id, $approval) method?
The text was updated successfully, but these errors were encountered: