Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kirigami] Missing data doesn't update as maps get downloaded #376

Open
PureTryOut opened this issue Mar 31, 2021 · 3 comments
Open

[Kirigami] Missing data doesn't update as maps get downloaded #376

PureTryOut opened this issue Mar 31, 2021 · 3 comments

Comments

@PureTryOut
Copy link
Contributor

Screenshot_20210331_092406

In the screenshot the Netherlands is still shown, even though it has already been downloaded. The text will update once all data is downloaded, but it would be nice to see what's left from the current point rather than from the start of downloading.

@rinigus
Copy link
Owner

rinigus commented Mar 31, 2021

It is showing as not available as it is probably not uncompressed yet. Bit confusing, I agree. I will put it into the box of 'nice to have when you have tons of time' issues.

Maybe have to rework the whole distribution handling of the maps and switch to some proper packaging solution, just that would also require some major work on it. As choosing some packaging format (RPM,DEB,...), configuring maps distribution server as repo server, and let OSM Scout Server subscribe to that repo and update using corresponding packaging library. Could be a project for someone to look into.

@PureTryOut
Copy link
Contributor Author

Packaging maps as a RPM or DEB? I don´t see why you would ever do that, just upload it as a compressed tar file with some good compression on it.

@rinigus
Copy link
Owner

rinigus commented Apr 2, 2021

Just to be clear: Idea is not to integrate with OS distro packaging, but make separate maps "root" folder on device which is maintained by some packaging lib/approach. In principle, that is what is happening now as well, just using rather primitive packaging routines written as a part of osm scout server.

The advantages of going into some upstream lib are as follows:

  • packaging lib would be able to calculate required space on device correctly. Right now, I am using "pessimistic" approach and somewhat overestimate the requirements as tiles from different countries may overlap.
  • packaging lib would be able to update the status in a less confusing way

There are probably some other advantages as well. Main cons is the work required to replace current working solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants