Clarify that Sstvala applies to virtual-instruction exceptions, too #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both illegal-instruction and virtual-instruction exceptions must populate stval with the faulting instruction. This is not a change; the behavior was already mandated by the following clause in the hypervisor spec: https://github.com/riscv/riscv-isa-manual/blob/65c6b5d3e69cdc2bd2658f9639fd10553c4b34e0/src/hypervisor.adoc#L2040-L2041 We are replicating that information here for added clarity.
|
should also be added to RVA/B23 profiles. |
|
I had already done so as part of the original PR. Or did you spot another place I missed? |
|
OK - mistake on my end. Will merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both illegal-instruction and virtual-instruction exceptions must populate stval with the faulting instruction.
This is not a change; the behavior was already mandated by the following clause in the hypervisor spec: https://github.com/riscv/riscv-isa-manual/blob/65c6b5d3e69cdc2bd2658f9639fd10553c4b34e0/src/hypervisor.adoc#L2040-L2041
We are replicating that information here for added clarity.