From cd0c4229ba318ab7c484f8165bd190b6de4412e1 Mon Sep 17 00:00:00 2001
From: Ved Shanbhogue <ved@rivosinc.com>
Date: Wed, 7 Feb 2024 14:42:09 -0600
Subject: [PATCH] update to new bitfield syntax

---
 model/riscv_insts_zicfiss.sail   | 8 ++++----
 model/riscv_sys_regs.sail        | 6 +++---
 model/riscv_zicfiss_control.sail | 6 +++---
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/model/riscv_insts_zicfiss.sail b/model/riscv_insts_zicfiss.sail
index 916d76043..f0b660b6f 100644
--- a/model/riscv_insts_zicfiss.sail
+++ b/model/riscv_insts_zicfiss.sail
@@ -88,9 +88,9 @@ function zicfiss_xSSE(priv : Privilege) -> bool = {
   if   priv == Machine 
   then false
   else if priv == Supervisor 
-  then menvcfg.SSE() == 0b1
+  then menvcfg[SSE] == 0b1
   else if haveSupMode()
-  then senvcfg.SSE() == 0b1
+  then senvcfg[SSE] == 0b1
   else false
 }
 
@@ -312,11 +312,11 @@ mapping clause assembly = SSAMOSWAP(aq, rl, rs2, rs1, size, rd)
       if haveZicfiss() & ssamoswap_width_valid(size)
 /* ****************************************************************** */
 function clause execute (SSAMOSWAP(aq, rl, rs2, rs1, width, rd)) = {
-  if   cur_privilege != Machine & menvcfg.SSE() == 0b0
+  if   cur_privilege != Machine & menvcfg[SSE] == 0b0
   then { handle_illegal(); RETIRE_FAIL }
   else if not(haveSupMode())
   then { handle_illegal(); RETIRE_FAIL }
-  else if cur_privilege == User & senvcfg.SSE() == 0b0
+  else if cur_privilege == User & senvcfg[SSE] == 0b0
   then { handle_illegal(); RETIRE_FAIL }
   else {
     match ext_data_get_addr(rs1, zeros(), SSReadWrite(Data, Data), width) {
diff --git a/model/riscv_sys_regs.sail b/model/riscv_sys_regs.sail
index ec0b73e1c..eadfefbc4 100644
--- a/model/riscv_sys_regs.sail
+++ b/model/riscv_sys_regs.sail
@@ -874,9 +874,9 @@ function legalize_menvcfg(o : Envcfg, v : bits(64)) -> Envcfg = {
 
 function legalize_senvcfg(o : Envcfg, v : bits(64)) -> Envcfg = {
   let v = Mk_Envcfg(v);
-  let o = update_FIOM(o, if sys_enable_writable_fiom() then v.FIOM() else 0b0);
+  let o = [o with FIOM = if sys_enable_writable_fiom() then v[FIOM] else 0b0];
   // Zicfiss - SSE: shadow stack enable - is ROZ in senvcfg if menvcfg.SSE is 0
-  let o = update_SSE(o, if haveZicfiss() & menvcfg.SSE() == 0b1 then v.SSE() else 0b0);
+  let o = [o with SSE = if haveZicfiss() & menvcfg[SSE] == 0b1 then v[SSE] else 0b0];
   // Other extensions are not implemented yet so all other fields are read only zero.
   o
 }
@@ -884,7 +884,7 @@ function legalize_senvcfg(o : Envcfg, v : bits(64)) -> Envcfg = {
 function get_senvcfg() -> bits(64) = {
   let o : Envcfg = senvcfg;
   // Zicfiss - SSE: shadow stack enable - is ROZ in senvcfg if menvcfg.SSE is 0
-  let o = update_SSE(o, if  haveZicfiss() & menvcfg.SSE() == 0b1 then o.SSE() else 0b0);
+  let o = [o with SSE = if haveZicfiss() & menvcfg[SSE] == 0b1 then o[SSE] else 0b0];
   o.bits()
 }
 
diff --git a/model/riscv_zicfiss_control.sail b/model/riscv_zicfiss_control.sail
index 3d13f8f73..cb3730f0c 100644
--- a/model/riscv_zicfiss_control.sail
+++ b/model/riscv_zicfiss_control.sail
@@ -88,9 +88,9 @@ function clause ext_is_CSR_defined(0x011, priv) = { // ssp
   if   priv == Machine 
   then true
   else if priv == Supervisor 
-  then menvcfg.SSE() == 0b1
+  then menvcfg[SSE] == 0b1
   else if haveSupMode()
-  then senvcfg.SSE() == 0b1
+  then senvcfg[SSE] == 0b1
   else false
 }
 function clause ext_read_CSR(0x011)          = Some(ssp)
@@ -101,7 +101,7 @@ function clause ext_write_CSR(0x011, value)  = {
    * Sail model does not support dynamic switching of UXL/SXL so that is
    * not considered in the following algorithm yet.
    */
-  if ( architecture(misa.MXL()) == Some(RV64) ) then
+  if ( architecture(misa[MXL]) == Some(RV64) ) then
     ssp[2 .. 2] = 0b0;
   Some(ssp);
 }