Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sail model uses old asm mnmonics for vmandn and vmorn #421

Closed
mdhayter opened this issue Mar 1, 2024 · 3 comments
Closed

Sail model uses old asm mnmonics for vmandn and vmorn #421

mdhayter opened this issue Mar 1, 2024 · 3 comments
Labels
good first issue Good for newcomers

Comments

@mdhayter
Copy link

mdhayter commented Mar 1, 2024

The mapping mmtype_mnemonic seems to be using the old vmandnot / vmornot rather than the new vmandn / vmorn

https://github.com/riscv/sail-riscv/blob/c287c34df944647fcfd1923e37f4d97466f264bd/model/riscv_insts_vext_mask.sail#L72C1-L73C1

See note in https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc section 15.1

Should be ok where aliases are used, but it is probably best to line up with the usage in riscv-opcodes/rv_v
@Timmmm Timmmm added the good first issue Good for newcomers label May 7, 2024
@ShivangMishra
Copy link
Contributor

@Timmmm I raised PR #465 for this issue. Does it look ok?

Alasdair pushed a commit that referenced this issue May 9, 2024
@ShivangMishra
Replace vmandnot and vmornot with vmandn and vmorn - Issue #421 (#465)
e3c5b0a 
Updates the instruction mnemonics for vmandn and vmorn

* replace mnemonics "vmandnot" and "vmornot" with "vmandn" and "vmorn" respectively

* renamed MM_VMORNOT and MM_VMANDNOT to match mnemonics
KotorinMinami pushed a commit to KotorinMinami/sail-riscv that referenced this issue May 9, 2024
@ShivangMishra @KotorinMinami
Replace vmandnot and vmornot with vmandn and vmorn - Issue riscv#421 (r…
4a5cdde 
…iscv#465)

Updates the instruction mnemonics for vmandn and vmorn

* replace mnemonics "vmandnot" and "vmornot" with "vmandn" and "vmorn" respectively

* renamed MM_VMORNOT and MM_VMANDNOT to match mnemonics
@ShivangMishra
Copy link
Contributor

@Timmmm can we close this issue?

@Timmmm
Copy link
Collaborator

Timmmm commented May 10, 2024

Yep

@Timmmm Timmmm closed this as completed May 10, 2024
bacam pushed a commit to bacam/sail-riscv that referenced this issue Jun 4, 2024
@ShivangMishra @bacam
Replace vmandnot and vmornot with vmandn and vmorn - Issue riscv#421 (r…
536ad6b 
…iscv#465)

Updates the instruction mnemonics for vmandn and vmorn

* replace mnemonics "vmandnot" and "vmornot" with "vmandn" and "vmorn" respectively

* renamed MM_VMORNOT and MM_VMANDNOT to match mnemonics
ThinkOpenly pushed a commit to ThinkOpenly/sail-riscv that referenced this issue Jul 3, 2024
@ShivangMishra @ThinkOpenly
Replace vmandnot and vmornot with vmandn and vmorn - Issue riscv#421 (r…
c62ab4d 
…iscv#465)

Updates the instruction mnemonics for vmandn and vmorn

* replace mnemonics "vmandnot" and "vmornot" with "vmandn" and "vmorn" respectively

* renamed MM_VMORNOT and MM_VMANDNOT to match mnemonics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Timmmm @mdhayter @ShivangMishra