Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector extension code corrections #276

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

XinlaiWan
Copy link
Collaborator

In this PR, there are some corrections of the V extension code after going through the spec once again and running ISA tests covering more configurations (rvv-atg). They are mostly about corner case illegal checks.

  1. Use register index instead of register name string when reading mask register v0, as suggested in the last PR.
  2. Update setting of CSR vtype.vill field in vset instructions and judgement of illegal vill when executing vector instructions.
  3. Update the condition check of SEW <= ELEN * LMUL for vset instructions. Violations will set vill according to the spec.
  4. Fix a bug in vnclip/vnclipu instructions when calculating shift width.

V extension has a huge number of instructions with subtle variations. It's prone to miss some corner cases or small details in both instruction semantic and coding style. Please comment if there are issues found in the code, and I'll fix them soon. After this PR is approved, I'll open the merging PR from vector-dev branch to the main branch.

@github-actions
Copy link

github-actions bot commented Jun 18, 2023

Unit Test Results

712 tests  ±0   712 ✔️ ±0   0s ⏱️ ±0s
    6 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 25d39ce. ± Comparison against base commit 3a3b1c0.

♻️ This comment has been updated with latest results.

@billmcspadden-riscv billmcspadden-riscv added the tgmm-agenda Tagged for the next Golden Model meeting agenda. label Jun 27, 2023
@billmcspadden-riscv billmcspadden-riscv merged commit 5872908 into riscv:vector-dev Jul 11, 2023
2 checks passed
@billmcspadden-riscv billmcspadden-riscv removed the tgmm-agenda Tagged for the next Golden Model meeting agenda. label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants