Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bool <-> bit mappings from riscv_types.sail #470

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

Timmmm
Copy link
Collaborator

@Timmmm Timmmm commented May 15, 2024

Use these mappings and change the other functions to be aliases of them.

Copy link

github-actions bot commented May 15, 2024

Test Results

712 tests  ±0   712 ✅ ±0   0s ⏱️ ±0s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit dcf8d01. ± Comparison against base commit eeb9270.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the old names made it more obvious which way the conversion goes but happy with either

@Timmmm
Copy link
Collaborator Author

Timmmm commented May 15, 2024

I feel like the old names made it more obvious which way the conversion goes but happy with either

Yeah I agree. Kind of hard to name these mappings.

@Timmmm
Copy link
Collaborator Author

Timmmm commented Jun 11, 2024

I think on reflection I'll add the original functions back as aliases to the mapping, i.e.

function bool_to_bits(...) = bool_bits(...)
function bits_to_bool(...) = bool_bits(...)

The names are definitely clearer and it will make this change smaller.

@Timmmm Timmmm marked this pull request as draft June 11, 2024 20:55
@Timmmm Timmmm changed the title Use bool <-> bit mappings from riscv_types.sail everywhere Use bool <-> bit mappings from riscv_types.sail Jun 12, 2024
@Timmmm Timmmm marked this pull request as ready for review June 12, 2024 10:20
@Timmmm Timmmm requested a review from arichardson July 4, 2024 11:07
Use these mappings and change the other functions to be aliases of them.
@Timmmm Timmmm merged commit b6cdb53 into riscv:master Jul 9, 2024
2 checks passed
@Timmmm Timmmm deleted the user/timh/bool_mappings branch August 30, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants