Check misalignment of AMOs before address translation #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichardson
approved these changes
May 15, 2024
Timmmm
force-pushed
the
user/timh/amo_alignment_check
branch
from
fe750b6
to
e4e09fb
Compare
Mudassir10X
reviewed
May 23, 2024
Mudassir10X
approved these changes
May 27, 2024
This is optional according to the spec - you can check afterwards. However 1. it seems extremely unlikely that any real designs will do that for atomics, which (ignoring Zam which the model doesn't support yet), always have to be aligned, and 2. the LR and SC instructions already check before address translation, so this wasn't even consistent. Ideally in future this would be configurable. This also includes a minor refactor to reuse the existing alignment checking code.
Timmmm
force-pushed
the
user/timh/amo_alignment_check
branch
from
e4e09fb
to
e1dcef1
Compare
|
I'll merge this tomorrow if nobody has any objections... |
ThinkOpenly
pushed a commit
to ThinkOpenly/sail-riscv
that referenced
this pull request
Jul 3, 2024
This is optional according to the spec - you can check afterwards. However 1. it seems extremely unlikely that any real designs will do that for atomics, which (ignoring Zam which the model doesn't support yet), always have to be aligned, and 2. the LR and SC instructions already check before address translation, so this wasn't even consistent. Ideally in future this would be configurable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is optional according to the spec - you can check afterwards. However
Ideally in future this would be configurable.
This also includes a minor refactor to reuse the existing alignment checking code.