Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor style fixes #476

Merged
merged 1 commit into from
May 23, 2024
Merged

Minor style fixes #476

merged 1 commit into from
May 23, 2024

Conversation

Timmmm
Copy link
Collaborator

@Timmmm Timmmm commented May 15, 2024

  • Remove unnecessary f variable
  • Remove redundant type delcaration for fetch.
  • Indentation

@Timmmm
Minor style fixes
6c758e9 
* Remove unnecessary `f` variable
* Remove redundant type delcaration for `fetch`.
* Indentation
@github-actions GitHub Actions
Copy link

Test Results

712 tests  ±0   712 ✅ ±0   0s ⏱️ ±0s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 6c758e9. ± Comparison against base commit e1242d8.

billmcspadden-riscv
billmcspadden-riscv approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@billmcspadden-riscv billmcspadden-riscv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@billmcspadden-riscv billmcspadden-riscv merged commit 66ebcc7 into riscv:master May 23, 2024
2 checks passed
billmcspadden-riscv pushed a commit that referenced this pull request May 24, 2024
@timsifive
Merge pull request #476 from riscv-software-src/env_args
d0d1b08 
Get gcc and gdb path from environment.
@Timmmm Timmmm deleted the user/timh/minor_fixes branch June 12, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alasdair Alasdair Alasdair approved these changes

@billmcspadden-riscv billmcspadden-riscv billmcspadden-riscv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Timmmm @Alasdair @billmcspadden-riscv