Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor floating point vector instructions and utilities into separate files #513

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

vmurali
Copy link
Contributor

@vmurali vmurali commented Jul 11, 2024

In addition to good software engineering practices, this also allows importing only the required files when floating point operations are not supported (for example, the file is commented out in https://github.com/microsoft/cheriot-sail/blob/main/Makefile#L49).

Copy link

github-actions bot commented Jul 12, 2024

Test Results

712 tests  ±0   712 ✅ ±0   0s ⏱️ ±0s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit e4f8fae. ± Comparison against base commit 6168768.

♻️ This comment has been updated with latest results.

@vmurali
Copy link
Contributor Author

vmurali commented Jul 18, 2024

Bump, any comments?

@Timmmm
Copy link
Collaborator

Timmmm commented Jul 22, 2024

Sorry took me a while to figure out wtf the git diff --color-moved colours meant. How has Phabricator had moved-line detection in its UI for years but Github still hasn't??

Anyway LGTM. I'll merge in a few days if nobody else objects.

@billmcspadden-riscv
Copy link
Collaborator

@vmurali : would you please resolve the conflicts.

…te files

In addition to good software engineering practices, this also allows importing only the required files when floating point operations are not supported (for example, the file is commented out in https://github.com/microsoft/cheriot-sail/blob/main/Makefile#L49).
@vmurali
Copy link
Contributor Author

vmurali commented Jul 22, 2024

Sorry took me a while to figure out wtf the git diff --color-moved colours meant. How has Phabricator had moved-line detection in its UI for years but Github still hasn't??

Anyway LGTM. I'll merge in a few days if nobody else objects.

I usually use git diff --color-moved=dimmed-zebra that greys out moved portions instead of giving (unhelpful) colors.

@vmurali : would you please resolve the conflicts.

@billmcspadden-riscv I resolved the conflicts. PTAL

@vmurali
Copy link
Contributor Author

vmurali commented Jul 23, 2024

Thanks! Can someone merge it before it becomes stale again?

@Timmmm
Copy link
Collaborator

Timmmm commented Jul 23, 2024

Yeah I'll just merge it now.

@Timmmm Timmmm merged commit 3ad92a4 into riscv:master Jul 23, 2024
2 checks passed
@vmurali
Copy link
Contributor Author

vmurali commented Jul 23, 2024

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants