Fix all Sail compilation warnings #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `pure`/`impure` annotations and remove some duplicate function declarations.
|
@Alasdair I wasn't sure if printing functions should count as pure or impure from Sail's perspective seeing as they're technically impure but the Sail model can't actually observe the impurity. |
From the Sail model's perspective the output is not observable so these are pure. Also the pure/impure is used for formal backends which don't actually print anything anyway.
Alasdair
approved these changes
Sep 10, 2024
|
@billmcspadden-riscv also this one can be merged. |
|
Btw I would recommend using squash and merge, especially when there's only one commit in the PR. Otherwise you get a needlessly convoluted commit history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
pure/impureannotations and remove some duplicate function declarations.