Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further vector refactoring and updates #559

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

Alasdair
Copy link
Collaborator

This PR has two commits:

  • The first simply removes another usage of undefined in the vector extension, and adds an additional type constraint to allow a runtime assertion to be removed on that function
  • The second removes the dec parameters from all the generic vectors in the vector extension (and some other usages, but it's 99% vector), so vector('n, dec, 'a) becomes just vector('n, 'a). For a while now these parameters haven't done anything and are only allowed for backwards compatability.

In the latest version of Sail these do nothing, and are only allowed
for backwards compatability reasons.
Copy link

Test Results

396 tests  ±0   396 ✅ ±0   0s ⏱️ ±0s
  4 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 7636462. ± Comparison against base commit 5a841c9.

@Timmmm Timmmm merged commit b3ca3a8 into riscv:master Sep 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants