Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertions for reviewer_id #58

Open
pbiecek opened this issue Jan 4, 2022 · 0 comments
Open

Add assertions for reviewer_id #58

pbiecek opened this issue Jan 4, 2022 · 0 comments

Comments

@pbiecek
Copy link
Member

pbiecek commented Jan 4, 2022

Some functions expect that reviewer_id is numeric (as stated in the documentation)
But if someone provides the character then they will not receive an error message despite the code not working correctly.

Possible fix:

add stopifnot( is.numeric(reviewer_id))
to rj:::add_reviewer_comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant