-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zip_paper
creates incomplete submissions
#69
Comments
Hi Simon, Apologise for the late reply. Additional files like figures or data can be included in the zip with the argument Another option is to auto-detect commonly used image folder names (img, figures, images, etc) and ask users whether they would like to include them. |
Yes, definitely better documentation should be the first step, in particular since this is supposed to be function to prepare submissions. I'm still a bit uneasy about the approach of using substring search to pick files - I think it would be better to define some guidelines on the structure instead - like R packages where we have well-defined directory names and structure for contents that is to be submitted. |
zip_paper
is very misleading as it doesn't create valid submissions unless the files follow very specific naming conventions which are not documented. It doesn't include any dependencies used in the sources such as images unless they happen to be in a sub-directory withname
in it (since all it does is to usename
as regexp). This causes issues with common conventions such as figures in thefigures
orimages
folder. Also the ZIP file does not include files necessary for the LaTeX rendering.zip_paper
to work. Ideally it would be nice if it could find the location of included files such as images automaticallypdflatex
The text was updated successfully, but these errors were encountered: