Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unmet dependencies #82

Closed
eloypnd opened this issue Mar 22, 2016 · 8 comments
Closed

unmet dependencies #82

eloypnd opened this issue Mar 22, 2016 · 8 comments

Comments

@eloypnd
Copy link

eloypnd commented Mar 22, 2016

There is some issue with deeper dependency buffertools. I get the following error message when trying to browserify:

Error: Cannot find module 'buffertools' from '.../node_modules/deeper

Therefore I can't get the JS bundle.

I am using react-jsonschema-form@0.17.1 with

  • node@5.1.1
  • babel-core@6.6.5
  • babelify@7.2.0
  • browserify@13.0.0
@n1k0
Copy link
Collaborator

n1k0 commented Mar 22, 2016

I had to deal with that as well, and solved it in the webpack configuration by ignoring this import.

You may want to do the same in your browserify configuration. You may also want file an issue to their repository, as I think they shouldn't do what they do, or at least the way they do it.

@cguedes
Copy link
Contributor

cguedes commented Apr 6, 2016

@n1k0 Tnks for the hint on this.

Shouldn't this note be on some README.md section (i.e. Troubleshooting)?

@cguedes
Copy link
Contributor

cguedes commented Apr 6, 2016

For people that use browserify the solution is to use the ignore method of browserify with 'buffertools':

    var bundler = browserify({ ... yourconfig ... }).ignore('buffertools')

@n1k0
Copy link
Collaborator

n1k0 commented Apr 6, 2016

Shouldn't this note be on some README.md section (i.e. Troubleshooting)?

You're most definitely right. I'm also considering switching to another similarily scoped lib, but can't find anything as tiny as "deeper"; eg. switching to lodash isEqual bumps the build from 61kb to 68 :/

@cguedes
Copy link
Contributor

cguedes commented Apr 6, 2016

Yes, that would be the best approach. In the meanwhile, we should add the README.md. I will PR that for you.

@n1k0
Copy link
Collaborator

n1k0 commented Apr 6, 2016

I will PR that for you.

That's awesome, thanks. On my end I have an idea to solve the problem in the deeper lib itself as described in othiym23/node-deeper#3 (comment); gonna work on a PR.

@cguedes
Copy link
Contributor

cguedes commented Apr 6, 2016

@n1k0 PR created: #124

@nuclearspike
Copy link

Thanks for the ".ignore('buffertools')" tip! I was completely stuck on this one and that fixed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants